Skip to content

Conversation

elmiko
Copy link

@elmiko elmiko commented Sep 3, 2025

testing out this fix

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2025
@openshift-ci openshift-ci bot requested review from joelsmith and maxcao13 September 3, 2025 19:38
Copy link

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elmiko
Copy link
Author

elmiko commented Sep 3, 2025

i broke the unit tests by changing a couple function definitions. i want to see if the e2e's pass.

@elmiko
Copy link
Author

elmiko commented Sep 4, 2025

/test e2e-gcp-operator

@elmiko
Copy link
Author

elmiko commented Sep 5, 2025

looks like the unit tests need more cleanup

@elmiko
Copy link
Author

elmiko commented Sep 10, 2025

/test unit

@elmiko
Copy link
Author

elmiko commented Sep 11, 2025

/retest

Copy link

openshift-ci bot commented Sep 11, 2025

@elmiko: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/git-history 3ee4158 link false /test git-history
ci/prow/e2e-hypershift 3ee4158 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant