WIP add IsNodeCandidateForDeletion clusterapi implementation #380
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
elmiko
force-pushed
the
ocpbugs-60790
branch
from
611335f to
c0051f4
Compare
|
/test e2e-aws-periodic-pre |
This function allows cloud providers to specify when a node is not a good candidate for deletion. This will occur before the autoscaler has begun to cordon, drain, and taint any node for deletion.
The initial implementation of this function for clusterapi will return that a node is not a good candidate for deletion when it belongs to a MachineDeployment that is currently rolling out an upgrade.
elmiko
force-pushed
the
ocpbugs-60790
branch
from
c0051f4 to
672f838
Compare
|
/retest |
|
/test e2e-hypershift |
|
@elmiko: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
this is to address OCPBUGS-60790, currently testing this fix.