-
Notifications
You must be signed in to change notification settings - Fork 40
WIP DO NOT MERGE Ocp4.18 57131 60790 x logs #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.18
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
/test unit |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ci/prow/unit |
@elmiko: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit |
/test e2e-aws-periodic-pre |
/test unit |
This change helps to prevent circular dependencies between the core and builder packages as we start to pass the AutoscalerOptions to the cloud provider builder functions.
this changes the options input to the cloud provider builder function so that the full autoscaler options are passed. This is being proposed so that cloud providers will have new options for injecting behavior into the core parts of the autoscaler.
this change adds a method to the AutoscalerOptions struct to allow registering a scale down node processor.
This change adds a custom scale down node processor for cluster api to reject nodes that are undergoing upgrade.
this change adds more logging at level 5 to help expose why a node is not matching for a pod.
this change adds logging for ready nodes and node infos before the ScaleUp call in RunOnce.
aa8718f
to
1289a5f
Compare
/test unit |
This change updates the `Process` function of the node info processor interface so that it can accept a second list of nodes. The second list contains all the nodes that are not in the first list. This will allow the mixed node info processor to properly detect unready and unschedulable nodes for use as templates.
1289a5f
to
43adc06
Compare
/test unit |
@elmiko: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
this is for testing