DO NOT MERGE - Testing #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anup Add 2 missing CA flags to param docs
Refactor - add factories for Recommender & ClusterFeedProvider
The goal is to allow customization of this logic for different use-case and cloudproviders.
Add informational UncappedTarged field to VPA api.
The error argument was omitted.
Also refactor Balancing processor a bit to make it easily extensible.
Fix Fatalf format string
In k8s 1.11, pod priority, and preemption is enabled by default. The API is under `v1beta`, and they do not need to be enabled.
…-in-1.11 Update FAQ on overprovisioning to account for k8s 1.11
This is preparatory work for handling resource related (stockout/quota-exceeded) error conditions in CA.
…odes-return-instance-struct-instead-instance-name-2063d NodeGroup.Nodes() return Instance struct instead instance name
On local hardware I have not seen this test fail using the current 50ms timeout. On AWS/CI I see this fail occasionally; I built and copied this test to an AWS node and run it repeatedly for ~1 hour. The min was 5ms and the max was 268ms, so bumping the timeout to 500ms. Signed-off-by: Andrew McDermott <[email protected]>
…ancing Move nodegroup balancing to processor, add GKE-specific implementation
Recommender capps recommendation according to policy.
…stWaitForOp gce: increase test timeout in TestWaitForOp
Modify execution_latency_seconds buckets
Fix broken link to VPA Admission Webhook readme
Pass on-event oomInfo without creating a new goroutine.
…mp deps Add a makefile target `revendor-test-e2e` that captures the runes to bump the e2e test dependencies.
This is no longer applicable.
This reworks `TestNodeGroup{Increase,Decrease}Size()` to use subtests.
The change is to ensure we are testing both MachineSets and
MachineDeployments in all cases we construct a nodegroup.
By switching to subtests it is easier to see those places where
machine deployments are not being tested as the the output for each
test function should show that MachineDeployment and MachineSet is
listed in the test name output.
```console
--- PASS: TestNodeGroupIncreaseSize (0.61s)
--- PASS: TestNodeGroupIncreaseSize/MachineSet (0.30s)
--- PASS: TestNodeGroupIncreaseSize/MachineSet/errors_because_delta_is_negative (0.10s)
--- PASS: TestNodeGroupIncreaseSize/MachineSet/errors_because_initial+delta_>_maxSize (0.10s)
--- PASS: TestNodeGroupIncreaseSize/MachineSet/no_error_as_within_bounds (0.10s)
--- PASS: TestNodeGroupIncreaseSize/MachineDeployment (0.30s)
--- PASS: TestNodeGroupIncreaseSize/MachineDeployment/errors_because_delta_is_negative (0.10s)
--- PASS: TestNodeGroupIncreaseSize/MachineDeployment/errors_because_initial+delta_>_maxSize (0.10s)
--- PASS: TestNodeGroupIncreaseSize/MachineDeployment/no_error_as_within_bounds (0.10s)
--- PASS: TestNodeGroupDecreaseSize (0.61s)
--- PASS: TestNodeGroupDecreaseSize/MachineSet (0.30s)
--- PASS: TestNodeGroupDecreaseSize/MachineSet/errors_because_delta_is_positive (0.10s)
--- PASS: TestNodeGroupDecreaseSize/MachineSet/errors_because_delta_exceeds_node_count (0.10s)
--- PASS: TestNodeGroupDecreaseSize/MachineSet/errors_because_size+delta_>=_len(nodes) (0.10s)
--- PASS: TestNodeGroupDecreaseSize/MachineDeployment (0.30s)
--- PASS: TestNodeGroupDecreaseSize/MachineDeployment/errors_because_delta_is_positive (0.10s)
--- PASS: TestNodeGroupDecreaseSize/MachineDeployment/errors_because_delta_exceeds_node_count (0.10s)
--- PASS: TestNodeGroupDecreaseSize/MachineDeployment/errors_because_size+delta_>=_len(nodes) (0.10s)
```
No code outside of the unit tests has been changed.
This reworks `TestNodeGroupMachineSetDeleteNodes` to use subtests. The
change is to ensure we are testing both MachineSets and
MachineDeployments in all cases we construct a nodegroup.
By switching to subtests it is easier to see those places where
machine deployments are not being tested as the the output for each
test function should show that MachineDeployment and MachineSet is
listed in the test name output.
```console
--- PASS: TestNodeGroupDeleteNodes (0.20s)
--- PASS: TestNodeGroupDeleteNodes/MachineSet (0.10s)
--- PASS: TestNodeGroupDeleteNodes/MachineDeployment (0.10s)
```
This reworks TestControllerNodeGroups to use subtests. The change is
to ensure we are testing both MachineSets and MachineDeployments in
all cases we construct a nodegroup.
By switching to subtests it is easier to see those places where
machine deployments are not being tested as the the output for each
test function should show that MachineDeployment and MachineSet is
listed in the test name output.
```console
--- PASS: TestControllerNodeGroups (0.61s)
--- PASS: TestControllerNodeGroups/MachineSet (0.30s)
--- PASS: TestControllerNodeGroups/MachineSet/errors_with_bad_annotations (0.10s)
--- PASS: TestControllerNodeGroups/MachineSet/success_with_zero_bounds (0.10s)
--- PASS: TestControllerNodeGroups/MachineSet/success_with_positive_bounds (0.10s)
--- PASS: TestControllerNodeGroups/MachineDeployment (0.30s)
--- PASS: TestControllerNodeGroups/MachineDeployment/errors_with_bad_annotations (0.10s)
--- PASS: TestControllerNodeGroups/MachineDeployment/success_with_zero_bounds (0.10s)
--- PASS: TestControllerNodeGroups/MachineDeployment/success_with_positive_bounds (0.10s)
```
Simplify test setup using `newMachineController()`.
Switch to using subtests vis-a-vis using t.Logf() to identify the test being run.
…okup
This reworks TestControllerNodeGroupForNodeLookup to use subtests. The
change is to ensure we are testing both MachineSets and
MachineDeployments in all cases we construct a nodegroup.
By switching to subtests it is easier to see those places where
machine deployments are not being tested as the the output for each
test function should show that MachineDeployment and MachineSet is
listed in the test name output.
```console
--- PASS: TestControllerNodeGroupForNodeLookup (0.61s)
--- PASS: TestControllerNodeGroupForNodeLookup/MachineSet (0.30s)
--- PASS: TestControllerNodeGroupForNodeLookup/MachineSet/lookup_is_nil_because_no_annotations (0.10s)
--- PASS: TestControllerNodeGroupForNodeLookup/MachineSet/lookup_is_nil_because_scaling_range_==_0 (0.10s)
--- PASS: TestControllerNodeGroupForNodeLookup/MachineSet/lookup_is_successful_because_scaling_range_>=_1 (0.10s)
--- PASS: TestControllerNodeGroupForNodeLookup/MachineDeployment (0.30s)
--- PASS: TestControllerNodeGroupForNodeLookup/MachineDeployment/lookup_is_nil_because_no_annotations (0.10s)
--- PASS: TestControllerNodeGroupForNodeLookup/MachineDeployment/lookup_is_nil_because_scaling_range_==_0 (0.10s)
--- PASS: TestControllerNodeGroupForNodeLookup/MachineDeployment/lookup_is_successful_because_scaling_range_>=_1 (0.10s)
```
All the others tests are not run in parallel and running this small subset with t.Parallel() buys us nothing.
Moved all test utility & setup functions into machineapi_controller_test.go. In the vast majority of the unit tests you need a controller so it makes sense to consolidate all the utilities in that file.
Check for explicit error mesages in TestNodeGroupIncreaseSize() and TestNodeGroupDecreaseSize(). These functions now only test the expected error cases on bad inputs. A follow-up PR will test for the success case which needs additional test setup code.
This adds the --kubeconfig path to the autoscaler options.
smarterclayton
force-pushed
the
downstream_rebase
branch
from
d9d819d to
3ffad39
Compare
|
@smarterclayton: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of how you'd merge the latest upstream into our master branch as a PR.
Requirements:
The flow described below preserves the three above and adds the following guarantee:
This flow is suitable for automation and should be (we want specific commit messages, for example) like
Rebase: Choosing <GIT DESCRIBE> <COMMIT_ID>The rough flow is:
-s ours)your pull request at this point is "everything new" and you get PR tests and the history is preserved