UPSTREAM: <carry>: openshift: clean up test setup #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
|
As this is still WIP /hold |
openshift-ci-robot
added
the
do-not-merge/hold
frobware
force-pushed
the
simplify-controller-unit-tests-v2
branch
6 times, most recently
from
076be26 to
6b835aa
Compare
openshift-ci-robot
added
size/XXL
frobware
force-pushed
the
simplify-controller-unit-tests-v2
branch
4 times, most recently
from
346f006 to
5d368ca
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/refresh |
|
/retest |
ingvagabund
reviewed
Apr 3, 2019
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_provider.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_controller_test.go
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_nodegroup_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_nodegroup_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_nodegroup_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_controller_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_controller_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_controller_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_controller_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/openshiftmachineapi/machineapi_controller_test.go
Outdated
Show resolved
Hide resolved
frobware
force-pushed
the
simplify-controller-unit-tests-v2
branch
4 times, most recently
from
3bdd54a to
ea8237b
Compare
|
@ingvagabund I believe I addressed your issues and observations - and thanks! |
|
/hold Holding pending final review and LGTM. At that point I want to squash a lot of these commits. |
openshift-ci-robot
added
the
do-not-merge/hold
|
LGTM, once squashed as you say I will add real lgtm |
|
/test images |
|
/test e2e-aws-operator |
Expose the internal type nodegroup at the controller level. This makes unit testing more feasible. The upper layers (i.e., the provider) convert to cloudprovider.<types>.
Use "machine.openshift.io/machine" as constant value throughout, not just in the tests.
Extract the nodegroup.Debug() format string as a const to share between said function and unit tests.
Shorten the test helper function names that create spec and configs for the unit tests. They previously had `must` as part of the name but they don't actually fail and/or return any error.
frobware
force-pushed
the
simplify-controller-unit-tests-v2
branch
from
c866ecc to
1a6228b
Compare
|
/refresh |
|
/test images |
|
/test e2e-aws-operator |
|
/retest |
|
@ingvagabund this has now been rebased as #76 has merged. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a rework of how the unit tests setup the controller and the objects under test. We previously accumulated three ways of setting up the tests - this change reduces that to using just one way, providing uniformity and consistency for all the tests.
The controller functions now return the
nodegrouptype rather thancloudprovider.<type>to make unit testing easier. The upper layers (i.e., the provider) convert thenodegrouptocloudprovider.NodeGroup. Anodegroupis acloudprovider.NodeGroupso the overall change here is really small - it only changes the function signature.Plus various drive-by fixes in the unit tests themselves to: