-
Notifications
You must be signed in to change notification settings - Fork 428
OCPBUGS-28230: add FallbackToLogsOnError for easier debugging #4147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@deads2k: This pull request references Jira Issue OCPBUGS-28230, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's technically also the MachineConfigServer pod (which normally is idle and doesn't really break), do you want to add that as well?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Good catch. That one is already set: https://github.com/openshift/machine-config-operator/blob/master/manifests/machineconfigserver/daemonset.yaml#L30 |
Ack, thanks for the clarification! This is for catching any remaining containers (rbac-proxy's) I see |
/override ci/prow/e2e-gcp-op-single-node Test is currently broken, and this change is unrelated |
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-gcp-op-single-node In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
/override ci/prow/e2e-gcp-op-single-node |
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-gcp-op-single-node In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
/override ci/prow/e2e-gcp-op-single-node |
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-gcp-op-single-node In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@deads2k: Jira Issue OCPBUGS-28230: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-28230 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-proxy-pull-test-container-v4.16.0-202401281812.p0.gc5f53e2.assembly.stream for distgit openshift-proxy-pull-test. |
All openshift operators must include FallbackToLogsOnError to ease debugging.