Skip to content

OCPBUGS-28230: add FallbackToLogsOnError for easier debugging #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 25, 2024

All openshift operators must include FallbackToLogsOnError to ease debugging.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request references Jira Issue OCPBUGS-28230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

All openshift operators must include FallbackToLogsOnError to ease debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 25, 2024
@openshift-ci openshift-ci bot requested review from djoshy and sinnykumari January 25, 2024 20:14
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's technically also the MachineConfigServer pod (which normally is idle and doesn't really break), do you want to add that as well?

Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2464fef and 2 for PR HEAD bee2519 in total

@deads2k
Copy link
Contributor Author

deads2k commented Jan 26, 2024

There's technically also the MachineConfigServer pod (which normally is idle and doesn't really break), do you want to add that as well?

Good catch. That one is already set: https://github.com/openshift/machine-config-operator/blob/master/manifests/machineconfigserver/daemonset.yaml#L30

@yuqi-zhang
Copy link
Contributor

Ack, thanks for the clarification! This is for catching any remaining containers (rbac-proxy's) I see

@djoshy
Copy link
Contributor

djoshy commented Jan 26, 2024

/override ci/prow/e2e-gcp-op-single-node

Test is currently broken, and this change is unrelated

Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-gcp-op-single-node

In response to this:

/override ci/prow/e2e-gcp-op-single-node

Test is currently broken, and this change is unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a3dbd65 and 1 for PR HEAD bee2519 in total

@deads2k
Copy link
Contributor Author

deads2k commented Jan 27, 2024

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Jan 27, 2024

/retest

@djoshy
Copy link
Contributor

djoshy commented Jan 27, 2024

/override ci/prow/e2e-gcp-op-single-node

Copy link
Contributor

openshift-ci bot commented Jan 27, 2024

@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-gcp-op-single-node

In response to this:

/override ci/prow/e2e-gcp-op-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@djoshy
Copy link
Contributor

djoshy commented Jan 28, 2024

/retest-required

@djoshy
Copy link
Contributor

djoshy commented Jan 28, 2024

/override ci/prow/e2e-gcp-op-single-node

Copy link
Contributor

openshift-ci bot commented Jan 28, 2024

@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-gcp-op-single-node

In response to this:

/override ci/prow/e2e-gcp-op-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Jan 28, 2024

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn bee2519 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c5f53e2 into openshift:master Jan 28, 2024
@openshift-ci-robot
Copy link
Contributor

@deads2k: Jira Issue OCPBUGS-28230: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28230 has not been moved to the MODIFIED state.

In response to this:

All openshift operators must include FallbackToLogsOnError to ease debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.16.0-202401281812.p0.gc5f53e2.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.

This was referenced Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants