Skip to content

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5238

/assign djoshy

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-59723 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.19] OCPBUGS-60265: Reintroduce cronjob that deletes MCN v1alpha1 CRD

In response to this:

This is an automated cherry-pick of #5238

/assign djoshy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-59723: Reintroduce cronjob that deletes MCN v1alpha1 CRD [release-4.19] OCPBUGS-60265: Reintroduce cronjob that deletes MCN v1alpha1 CRD Aug 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 12, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-60265, which is invalid:

  • expected dependent Jira Issue OCPBUGS-59723 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #5238

/assign djoshy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor

djoshy commented Aug 12, 2025

/lgtm

/label backport-risk-assessed

@djoshy
Copy link
Contributor

djoshy commented Aug 12, 2025

/retest-required

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 12, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@djoshy
Copy link
Contributor

djoshy commented Aug 12, 2025

/retest-required

@bryan-cox
Copy link
Member

/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance

Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

@bryan-cox: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a65994d0-7790-11f0-9583-28eec492d40b-0

@bryan-cox
Copy link
Member

/hold

I believe this PR caused us to regress on 4.20 - I think this might have regressed periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-azure-aks-ovn-conformance.

Our AKS conformance is currently passing well on 4.19 so I want to see if this job I triggered causes the same issues on 4.19 that we are seeing on the 4.20 test.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
@bryan-cox
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
@ptalgulk01
Copy link

Pre-merge tested:
Verified using IPI based AWS on 4.18 cluster.

  • Install 4.18 cluster, applied CRD
  • Upgrade the cluster to this PR image
  • Monitor the logs for cluster-version-operator
$ oc logs cluster-version-operator-7487f8fcc-n2sh4  -n openshift-cluster-version | grep -i cronjob
I0813 09:55:01.842039       1 sync_worker.go:1041] Running sync for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (780 of 921)
I0813 09:55:01.856299       1 sync_worker.go:1056] Done syncing for cronjob "openshift-machine-config-operator/machine-config-nodes-crd-cleanup" (780 of 921)
  • Check the cronjob and job deployed
$ oc get job -n openshift-machine-config-operator
NAME                                        STATUS     COMPLETIONS   DURATION   AGE
machine-config-nodes-crd-cleanup-29251307   Complete   1/1           2m2s       54m

$ oc get cronjob -n openshift-machine-config-operator 
NAME                               SCHEDULE    TIMEZONE   SUSPEND   ACTIVE   LAST SCHEDULE   AGE
machine-config-nodes-crd-cleanup   * * * * *        True      0        43m             44m
  • Check the cluster is upgraded
$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.19.0-0-2025-08-13-072359-test-ci-ln-77klshk-latest   True        False         58m     Cluster version is 4.19.0-0-2025-08-13-072359-test-ci-ln-77klshk-latest

$oc get crd | grep "machineconfignode"
empty

Note: For now MCN is not GA yet so CRD output for MCN is empty because CRD has got deleted and cleanup pod got removed during the pod.

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Aug 13, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-60265, which is invalid:

  • expected dependent Jira Issue OCPBUGS-59723 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #5238

/assign djoshy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor

djoshy commented Aug 14, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 14, 2025
@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-60265, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-59723 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-59723 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr August 14, 2025 14:41
@openshift-merge-bot openshift-merge-bot bot merged commit 366ecc0 into openshift:release-4.19 Aug 14, 2025
18 of 20 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-60265: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60265 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #5238

/assign djoshy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202508141509.p0.g366ecc0.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-08-14-184304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.