Skip to content

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Sep 22, 2025

This PR is also for 4.21 when the branch is created. Cherrypicking to 4.20 and 4.19 also.

https://issues.redhat.com/browse/OSDOCS-16248

Link to docs preview:
About checking machine config node status -- Updated oc get machineconfig command output example and added Age to Table 1.
Checking machine config node status -- Updated oc get machineconfig command output example.

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 22, 2025

🤖 Mon Sep 29 15:01:30 - Prow CI generated the docs preview:

https://99487--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/index.html

@mburke5678
Copy link
Contributor Author

@isabella-janssen PTAL

@isabella-janssen
Copy link
Member

/lgtm

This looks good to me and should be good to go once openshift/api#2497 merges. Thanks @mburke5678!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2025
@mburke5678
Copy link
Contributor Author

@ptalgulk01 Can you PTAL?

@ptalgulk01
Copy link

looks good

@mburke5678 mburke5678 added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 26, 2025
@dfitzmau dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 29, 2025
@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 29, 2025

Hi, @mburke5678 . Would you be OK to squash the 2 commits into 1 commit? When this is fixed, PR LGTM.

@mburke5678 mburke5678 force-pushed the mco-mcn-add-age-column branch from 7d3b491 to c988c31 Compare September 29, 2025 14:46
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
Copy link

openshift-ci bot commented Sep 29, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Sep 29, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 merged commit 46bdb97 into openshift:main Sep 29, 2025
2 checks passed
@mburke5678 mburke5678 deleted the mco-mcn-add-age-column branch September 29, 2025 16:49
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.19

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@mburke5678: new pull request created: #99824

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #99825

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 branch/enterprise-4.20 merge-review-in-progress Signifies that the merge review team is reviewing this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants