Skip to content

Sync olm config #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

awgreene
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from anik120 and hasbro17 December 16, 2021 13:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@awgreene awgreene force-pushed the sync-olm-config branch 3 times, most recently from bcde23a to f68fb65 Compare December 16, 2021 13:44
awgreene and others added 2 commits December 16, 2021 06:27
This commit introduces a controller for the olmConfig CRD.
The olmConfig CRD will be used to configure olm's behavior
on cluster. As of today, this CRD introduces the ability
for customer to disable copied csvs for operators installed
in allNamespace mode. When copied csv are disabled, an event
will be created in the operators namespace signaling that
it has no copied csvs and that users on the cluster may
have difficulty identifying which operators are available
in a given namespace.

Signed-off-by: Alexander Greene <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 52f368db86d24cb968f0439131a5788d0bcd5159
@awgreene awgreene changed the title WIP: Sync olm config Sync olm config Dec 16, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2021
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@awgreene
Copy link
Contributor Author

/retest

2 similar comments
@awgreene
Copy link
Contributor Author

/retest

@awgreene
Copy link
Contributor Author

/retest

@anik120
Copy link
Contributor

anik120 commented Dec 16, 2021

/hold
/close in favor of #236

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

@awgreene: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor Author

Closing in favor of #236

@awgreene awgreene closed this Dec 16, 2021
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Apr 14, 2022
This commit introduces the upgradeStrategy field to the operatorGroup
type. The upgradeStrategy field defines OLM behavior when upgrading
operators in the namespace. Two upgrade strategies are currently
supported, "Default" and "TechPreviewUnsafeFailForward".

The "Default" strategy mimics existing behavior.

The "TechPreviewUnsafeFailForward" strategy allows users to recover
from failed installPlans or failed clusterServiceVersions, it should
be noted that these upgrades are unsafe and can lead to unpredictable
behavior and potentially dataloss.

Upstream-repository: api
Upstream-commit: 33310d6154f344da5494c788451bd34cdf54711c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants