OPRUN-3221: 🌱 fix xplat compile for of-tools image; hide utest files from git; use rhel8 art builder image

[grokspawn]

This change enables multi-platform image build.

opm compile is a bit of an odd duck because it requires clang for sqlite integration, and is dependent on the linux/amd64 builder image to generate darwin/windows binaries. Because of that dependency, the cross make target is only triggered for linux/amd64-based platforms.

Instead of re-plumbing the entire build process for these binaries, this will use a wildcard to copy all opm binaries. This is analogous to how operator-registry does it, but restricting to just the opm binaries.

This results in linux/amd64 output:

└── tools                                           
    ├── darwin-amd64-opm                            
    ├── opm                                         
    ├── opm-rhel8                                   
    ├── opm-rhel9                                   
    └── windows-amd64-opm     

The cross-compiled binaries will still require ARCH/OS-specific unpacking for mirrors.openshift.com

[grokspawn]

/retest

[grokspawn]

/retest

since #767 merged y'day

[openshift-ci-robot]

@grokspawn: This pull request references OPECO-3232 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

This change enables multi-platform image build.

opm compile is a bit of an odd duck because it requires clang for sqlite integration, and is dependent on the linux/amd64 builder image to generate darwin/windows binaries. Because of that dependency, the cross make target is only triggered for linux/amd64-based platforms.

Instead of re-plumbing the entire build process for these binaries, this will use a wildcard to copy all opm binaries. This is analogous to how operator-registry does it, but restricting to just the opm binaries.

This results in linux/amd64 output:

└── tools                                           
   ├── darwin-amd64-opm                            
   ├── opm                                         
   ├── opm-rhel8                                   
   ├── opm-rhel9                                   
   └── windows-amd64-opm     

The cross-compiled binaries will still require ARCH/OS-specific unpacking for mirrors.openshift.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

/retest

[openshift-ci-robot]

@grokspawn: This pull request references OPRUN-3221 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

This change enables multi-platform image build.

opm compile is a bit of an odd duck because it requires clang for sqlite integration, and is dependent on the linux/amd64 builder image to generate darwin/windows binaries. Because of that dependency, the cross make target is only triggered for linux/amd64-based platforms.

Instead of re-plumbing the entire build process for these binaries, this will use a wildcard to copy all opm binaries. This is analogous to how operator-registry does it, but restricting to just the opm binaries.

This results in linux/amd64 output:

└── tools                                           
   ├── darwin-amd64-opm                            
   ├── opm                                         
   ├── opm-rhel8                                   
   ├── opm-rhel9                                   
   └── windows-amd64-opm     

The cross-compiled binaries will still require ARCH/OS-specific unpacking for mirrors.openshift.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Ximinhan]

/retest-required

[grokspawn]

IMO we should ignore the failing e2e-gcp-olm, since it's not related to this PR's changes of the operator-framework-tools.Dockerfile or gitignore filtering out utest leftover artifacts.

[perdasilva]

/retest

[tmshort]

/retest

[grokspawn]

/retest

[Ximinhan]

IMO we should ignore the failing e2e-gcp-olm, since it's not related to this PR's changes of the operator-framework-tools.Dockerfile or gitignore filtering out utest leftover artifacts.

can you help make this pr merged?

[tmshort]

/retest

[tmshort]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [grokspawn,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tmshort]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD dc02939 and 2 for PR HEAD b394079 in total

[perdasilva]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 092123a and 1 for PR HEAD b394079 in total

[grokspawn]

/retest

[perdasilva]

/lgtm

[perdasilva]

/label backport-risk-assessed

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 092123a and 2 for PR HEAD 893b225 in total

[perdasilva]

/retest

[perdasilva]

/retest

[openshift-ci]

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-registry-container-v4.17.0-202406211242.p0.g06c943a.assembly.stream.el9 for distgit operator-registry.
All builds following this will include this PR.

[grokspawn]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@grokspawn: #770 failed to apply on top of branch "release-4.16":

Applying: UPSTREAM: <carry>: fix xplat compile for of-tools image; hide utest files from git; use rhel8 art builder image
Using index info to reconstruct a base tree...
M	operator-framework-tools.Dockerfile
Falling back to patching base and 3-way merge...
Auto-merging operator-framework-tools.Dockerfile
CONFLICT (content): Merge conflict in operator-framework-tools.Dockerfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 UPSTREAM: <carry>: fix xplat compile for of-tools image; hide utest files from git; use rhel8 art builder image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.