OCPBUGS-30333: Move Helm to bingo dep and update it #837
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@bentito: This pull request references Jira Issue OCPBUGS-30333, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@bentito: This pull request references Jira Issue OCPBUGS-30333, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@bentito: This pull request references Jira Issue OCPBUGS-30333, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@perdasilva: This pull request references Jira Issue OCPBUGS-30333, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
lgtm, but I'll just stick one label on here in case someone else wants to 👀 today. Otherwise I'll try to circle back around and merge. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bentito, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
Signed-off-by: Brett Tofel <[email protected]>
bentito
force-pushed
the
bingoify-monorepo
branch
from
1d3453f to
4e3cd64
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
openshift-ci
bot
added
tide/merge-method-squash
|
@bentito: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 7915649
into
openshift:master
|
@bentito: Jira Issue OCPBUGS-30333: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30333 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: operator-lifecycle-manager |
|
[ART PR BUILD NOTIFIER] Distgit: operator-registry |
|
[ART PR BUILD NOTIFIER] Distgit: ose-operator-framework-tools |
|
/jira refresh |
|
@m1kola: Jira Issue OCPBUGS-30333 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
* Add bingo for Helm dep * Add bingo for Helm dep - vendor changes Signed-off-by: Brett Tofel <[email protected]> * Rm debug statement Signed-off-by: Brett Tofel <[email protected]> * Sync bingo go version with toolchain go version Signed-off-by: Brett Tofel <[email protected]> * Some Go debugging lines to debug helm bin path Signed-off-by: Brett Tofel <[email protected]> * Add helm dependency to verify target Signed-off-by: Brett Tofel <[email protected]> * Move down the bingo include to protect early defs Signed-off-by: Brett Tofel <[email protected]> --------- Signed-off-by: Brett Tofel <[email protected]>
We're adding
bingoto the top level of this monorepo. In doing this we are also changing the dependency to a version of Helm that is free of the target bug.Actual files in need of review:
.bingo/*
Makefile
go.mod
go.sumscripts/generate_crds_manifests.sh
tools.go