Skip to content

OCPBUGS-49622: Fix leaderelection settings #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

OCPBUGS-49622: Fix leaderelection settings #251

merged 1 commit into from
Jan 30, 2025

Conversation

LalatenduMohanty
Copy link
Member

This is a manual backport of #249 to fix leaderelection settings

@LalatenduMohanty
UPSTREAM: <carry>: Fix leaderelection settings
faf2f23 
This is a manual backport of openshift#249
to fix leaderelection settings

Signed-off-by: Lalatendu Mohanty <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 29, 2025
@openshift-ci-robot
Copy link

@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-49622, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-48765 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48765 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual backport of #249 to fix leaderelection settings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joelanford
Copy link
Member

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 29, 2025
@openshift-ci openshift-ci bot requested review from dtfranz and joelanford January 29, 2025 19:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@LalatenduMohanty
Copy link
Member Author

Catalogd PR openshift/operator-framework-catalogd#127

@LalatenduMohanty LalatenduMohanty mentioned this pull request Jan 29, 2025
Merged
@oceanc80
Copy link
Contributor

/retest

@camilamacedo86
Copy link
Contributor

/test okd-scos-e2e-aws-ovn

camilamacedo86
camilamacedo86 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, joelanford, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bandrade
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 193faf3 into openshift:release-4.18 Jan 30, 2025
8 of 9 checks passed
@openshift-ci-robot
Copy link

@LalatenduMohanty: Jira Issue OCPBUGS-49622: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49622 has been moved to the MODIFIED state.

In response to this:

This is a manual backport of #249 to fix leaderelection settings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.18.0-202501301814.p0.g193faf3.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@dtfranz dtfranz Awaiting requested review from dtfranz

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@bandrade bandrade

@joelanford joelanford

@camilamacedo86 camilamacedo86

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.