Skip to content

Allow use of common modules individually, add styling for messages #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

jeff-phillips-18
Copy link
Member

This PR allows applications to include either the UI or Services module or both by providing three JS files: one for UI components, one for services, and one that includes both. The default is both so this does not effect any applications currently using this package.

Added some clean up of Gruntfile and added some missing styling for notification messages.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Longer term, we might use Patternfly toast notifications in place of messenger. That was added before the Patternfly toasts existed.

@jeff-phillips-18
Copy link
Member Author

Agreed. I figured that is coming.

@dtaylor113 dtaylor113 merged commit 4a6361a into openshift:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants