Add INI config utility to common/util module #641
+280
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a new INI manipulation utility with the ability to extend service configurations (customServiceConfig) by adding key-value pairs to specific sections. It includes comprehensive test coverage for various scenarios, including section detection, key validation, and edge cases. This utility does not replace existing keys if they are already specified via user input, nor does it add a new section if one does not already exist in the specified configuration. This design preserves the original purpose of customServiceConfig as user input. Related: https://issues.redhat.com/browse/OSPRH-14309 Signed-off-by: Francesco Pantano <[email protected]>
stuggi
reviewed
Sep 29, 2025
| // Check if key already exists in target section | ||
| if token == customServiceConfigExtend.Key && sectionIndex > -1 && | ||
| sectionName == customServiceConfigExtend.Section { | ||
| errMsg := fmt.Errorf("%w: key %s in section %s", ErrKeyAlreadyExists, token, sectionName) |
There was a problem hiding this comment.
the openstack config is not strictly speaking ini config where you always have only once a parameter (key) in a section. there are services where it is valid to have multiple keys with the same name. e.g. in nova for pci passthrough, like the pci_passthrough_alias parameter.
There was a problem hiding this comment.
maybe IniOption should have a parameter to allow multiple of the same kind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new
INImanipulation utility with the ability to process/extend service configurations (customServiceConfig) by addingkey/valuepairs to specific sections. It includes comprehensive test coverage for various scenarios, including section detection, key validation, and edge cases. This utility does not replace existing keys if they are already specified via user input, nor does it add a new section if one does not already exist in the specified configuration. This design preserves the original purpose ofcustomServiceConfigas user input.Note: Since we already process
customServiceConfigin storage operators, lib-common seems to be a good fit for the use case.Related: https://issues.redhat.com/browse/OSPRH-14309