fix: get close tab shortcut from key-binding-registry #4606
+7
โ2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pengxingjian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
## Walkthrough
ๆฌๆฌกๆดๆนไผๅไบ็ผ่พๅจๆ ็ญพ้กตๅ
ณ้ญๆ้ฎ็ๆ็คบไฟกๆฏ๏ผๅจๆ่ทๅๅนถๆพ็คบโeditor.closeโๅฝไปค็ๅฎ้
ๅฟซๆท้ฎ๏ผ่ไธๅๆ นๆฎๅนณๅฐ็กฌ็ผ็ ไธบโโWโๆโCtrl+Wโใๅ
ถไฝ็ปไปถๅๆๅก้ป่พไฟๆไธๅใ
## Changes
| ๆไปถ่ทฏๅพ | ๅๆดๆ่ฆ |
|------------------------------------------------------------------|--------------------------------------------|
| packages/design/src/browser/override/editor-tab.service.tsx | ๅจๆ่ทๅโeditor.closeโๅฝไปค็ๅฟซๆท้ฎ๏ผๅนถๅจๅ
ณ้ญๆ ็ญพ้กตๆ้ฎ็ๆ็คบไธญๆพ็คบ๏ผๆฟๆขๅๆ็็กฌ็ผ็ ๆนๅผ๏ผ่ฐๆดๆ็คบๅผนๅบไฝ็ฝฎใ|
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant EditorTabCloseComponent
participant KeybindingRegistry
User->>EditorTabCloseComponent: ้ผ ๆ ๆฌๅๅ
ณ้ญๆ้ฎ
EditorTabCloseComponent->>KeybindingRegistry: ๆฅ่ฏข"editor.close"ๅฟซๆท้ฎ
KeybindingRegistry-->>EditorTabCloseComponent: ่ฟๅๅฟซๆท้ฎไฟกๆฏ
EditorTabCloseComponent-->>User: ๆพ็คบๅ
ๅซๅฎ้
ๅฟซๆท้ฎ็ๆ็คบไฟกๆฏEstimated code review effort1 (~5 minutes) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
๐งน Nitpick comments (2)
packages/design/src/browser/override/editor-tab.service.tsx (2)
23-26: ๅฎ็ฐ้ป่พๆญฃ็กฎ๏ผไฝๅฏไปฅ่ฟ่กไผๅๅจๆ่ทๅๅฟซๆท้ฎ็ๅฎ็ฐ้ป่พๆญฃ็กฎ๏ผๆๅๆฟไปฃไบ็กฌ็ผ็ ็ๅนณๅฐ็นๅฎๅฟซๆท้ฎใไธ่ฟๆๅ ไธชๆน่ฟๅปบ่ฎฎ๏ผ
- ็ฌฌ25่กๅฏไปฅไฝฟ็จๅฏ้้พๆไฝ็ฌฆๆฅ็ฎๅไปฃ็
- ้ป่พๆธ ๆฐ๏ผๆญฃ็กฎๅค็ไบๅ้ๆ ๅต
ๅบ็จไปฅไธไผๅ๏ผ
- const keyBinds = keybindingRegistry.getKeybindingsForCommand('editor.close'); - const keyBinding = keyBinds && keyBinds[0]; + const keyBinding = keybindingRegistry.getKeybindingsForCommand('editor.close')?.[0];
27-27: ่่ useMemo ไพ่ตๆฐ็ป
useMemo็ไพ่ตๆฐ็ปไธบ็ฉบ๏ผไฝ่ฎก็ฎไพ่ตไบshortCutๅ้ใๅฆๆ่ฟ่กๆถๅฏ่ฝๅจๆๆดๆฐๅฟซๆท้ฎ็ปๅฎ๏ผๅปบ่ฎฎๅฐshortCutๆทปๅ ๅฐไพ่ตๆฐ็ปไธญใ- const title = useMemo(() => formatLocalize('editor.closeTab.title', shortCut), []); + const title = useMemo(() => formatLocalize('editor.closeTab.title', shortCut), [shortCut]);ๅฆๆๅฟซๆท้ฎ็ปๅฎๅจ่ฟ่กๆถๆฏ้ๆ็๏ผๅฝๅๅฎ็ฐไนๆฏๅฏไปฅๆฅๅ็ใ
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
๐ Files selected for processing (1)
packages/design/src/browser/override/editor-tab.service.tsx(2 hunks)
๐งฐ Additional context used
๐ง Learnings (1)
packages/design/src/browser/override/editor-tab.service.tsx (1)
Learnt from: bytemain
PR: opensumi/core#4088
File: packages/ai-native/src/browser/widget/inline-stream-diff/live-preview.decoration.tsx:73-74
Timestamp: 2024-10-12T07:43:08.790Z
Learning: ๅจ `LivePreviewDiffDecorationModel` ็ฑป๏ผไฝไบ `packages/ai-native/src/browser/widget/inline-stream-diff/live-preview.decoration.tsx`๏ผไธญ๏ผ้่ฟไพ่ตๆณจๅ
ฅ๏ผ`@Autowired`๏ผไป module ็ `providers` ๅฃฐๆไธญ่ทๅ็ไพ่ต๏ผๅฆ `_onPartialEditEvent`๏ผ๏ผๅ
ถ้ๆฏ้ป่พ็ฑ `ClientApp` ็็ๅฝๅจๆ็ฎก็๏ผไธ้่ฆๆๅจ่ฐ็จ `dispose()` ่ฟ่ก้ๆฏใ
๐ช Biome (1.9.4)
packages/design/src/browser/override/editor-tab.service.tsx
[error] 25-25: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
๐ Additional comments (1)
packages/design/src/browser/override/editor-tab.service.tsx (1)
4-4: ๅฏผๅ ฅๅๆดๆญฃ็กฎๆญฃ็กฎๆทปๅ ไบ
KeybindingRegistryๅฏผๅ ฅ๏ผ่ฟๆฏๅฎ็ฐๅจๆ่ทๅๅฟซๆท้ฎๅ่ฝๆๅฟ ้็ใ
|
LGTMใ |
done |
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## main #4606 +/- ##
========================================
Coverage 52.61% 52.61%
========================================
Files 1687 1687
Lines 104341 104341
Branches 22668 22816 +148
========================================
Hits 54899 54899
Misses 41081 41081
Partials 8361 8361
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. ๐ New features to boost your workflow:
|
erha19
previously approved these changes
Jul 21, 2025
Lint ๆฅ้ๅค็ไธไธ @bubkoo
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
fix #4604
Changelog
Summary by CodeRabbit