fix: cleanup kas public key create error messages #1887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
approved these changes
Jan 28, 2025
jakedoublev
approved these changes
Jan 28, 2025
Are you typically ignoring any changes that automatically happen locally to it?
Right now the cli doesn't do anything special and just returns the error message it gets back from an rpc call so I think it will help a little. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.39](service/v0.4.38...service/v0.4.39) (2025-02-27) ### Features * add ability to retrieve policy resources by id or name ([#1901](#1901)) ([deb4455](deb4455)) * **core:** EXPERIMENTAL: EC-wrapped key support ([#1902](#1902)) ([652266f](652266f)) * **policy:** adds new public keys table ([#1836](#1836)) ([cad5048](cad5048)) ### Bug Fixes * add pagination to list public key mappings response ([#1889](#1889)) ([9898fbd](9898fbd)) * cleanup kas public key create error messages ([#1887](#1887)) ([59f7d0e](59f7d0e)) * **core:** Autobump service ([#1875](#1875)) ([4b6c335](4b6c335)) * **core:** Autobump service ([#1895](#1895)) ([08a2048](08a2048)) * **core:** Autobump service ([#1919](#1919)) ([f902295](f902295)) * **core:** Autobump service ([#1945](#1945)) ([d2e37ca](d2e37ca)) * **core:** Autobump service ([#1950](#1950)) ([7270080](7270080)) * **core:** Autobump service ([#1952](#1952)) ([b20123e](b20123e)) * **core:** Fixes for ec-wrapped from js client ([#1923](#1923)) ([3a66485](3a66485)) * **core:** Fixes protoJSON parse bug on ec rewrap ([#1943](#1943)) ([9bebfd0](9bebfd0)) * **core:** improve logging and errors on rewrap ([#1906](#1906)) ([84339d6](84339d6)) * **core:** Requires unique kids ([#1905](#1905)) ([c1b380c](c1b380c)) * filter total count on list public key operations ([#1884](#1884)) ([8df0adc](8df0adc)) * **sdk:** Fix compatibility between bulk and non-bulk rewrap ([#1914](#1914)) ([74abbb6](74abbb6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As I was working on the cli the error messages I originally implemented felt too generic. Here is another stab at making them more clear when create a new public key fails.
Checklist
Testing Instructions