Skip to content

fix(core): Requires unique kids #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2025
Merged

fix(core): Requires unique kids #1905

merged 3 commits into from
Feb 5, 2025

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Feb 4, 2025 •
edited
Loading

Proposed Changes

  • When loading KAS keys, validate that key identifiers are unique
  • This will be required as we move to a key ID - first (instead of alg first) method of selecting keys
  • While here, moved some of the 'legacy conversion' code into more testable functions and generally improved testing and handling/detection of error conditions, including increasing test coverage of loading/displaying EC keys

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru
fix(core): Requires unique kids
21861f3 
- When loading KAS keys, validate that key identifiers are unique
- This will be required as we move to a key ID - first (instead of alg first) method of selecting keys
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner February 4, 2025 22:16
jentfoo
jentfoo reviewed Feb 4, 2025
View reviewed changes
@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners February 5, 2025 14:41
mkleene
mkleene approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@mkleene mkleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, the only thing I'd say suggest is that we could be a bit more fussy with the types and have a map[string]rsaKeyLIst or something that that it's clear that we will never fail to pull an RSA or ECC key out of the map.

@dmihalcik-virtru dmihalcik-virtru added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit c1b380c Feb 5, 2025
23 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/unique-kids branch February 5, 2025 17:10
@opentdf-automation opentdf-automation bot mentioned this pull request Feb 5, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2025
@opentdf-automation
chore(main): release service 0.4.39 (#1871)
d7b430b 
🤖 I have created a release *beep* *boop*
---


##
[0.4.39](service/v0.4.38...service/v0.4.39)
(2025-02-27)


### Features

* add ability to retrieve policy resources by id or name
([#1901](#1901))
([deb4455](deb4455))
* **core:** EXPERIMENTAL: EC-wrapped key support
([#1902](#1902))
([652266f](652266f))
* **policy:** adds new public keys table
([#1836](#1836))
([cad5048](cad5048))


### Bug Fixes

* add pagination to list public key mappings response
([#1889](#1889))
([9898fbd](9898fbd))
* cleanup kas public key create error messages
([#1887](#1887))
([59f7d0e](59f7d0e))
* **core:** Autobump service
([#1875](#1875))
([4b6c335](4b6c335))
* **core:** Autobump service
([#1895](#1895))
([08a2048](08a2048))
* **core:** Autobump service
([#1919](#1919))
([f902295](f902295))
* **core:** Autobump service
([#1945](#1945))
([d2e37ca](d2e37ca))
* **core:** Autobump service
([#1950](#1950))
([7270080](7270080))
* **core:** Autobump service
([#1952](#1952))
([b20123e](b20123e))
* **core:** Fixes for ec-wrapped from js client
([#1923](#1923))
([3a66485](3a66485))
* **core:** Fixes protoJSON parse bug on ec rewrap
([#1943](#1943))
([9bebfd0](9bebfd0))
* **core:** improve logging and errors on rewrap
([#1906](#1906))
([84339d6](84339d6))
* **core:** Requires unique kids
([#1905](#1905))
([c1b380c](c1b380c))
* filter total count on list public key operations
([#1884](#1884))
([8df0adc](8df0adc))
* **sdk:** Fix compatibility between bulk and non-bulk rewrap
([#1914](#1914))
([74abbb6](74abbb6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkleene mkleene mkleene approved these changes

@jentfoo jentfoo jentfoo approved these changes

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmihalcik-virtru @mkleene @jentfoo @pflynn-virtru