-
Notifications
You must be signed in to change notification settings - Fork 24
Closed
Description
We should improve our usage with http.Client
. We don't currently reuse http clients, or define them in a consistent way in our Go code. This leads to several potential concerns:
- A lack of reuse prevents the ability to gain potential performance gains through connection pooling. SSL handshakes are notably slow, we likely are able to achieve real performance gains by being able to reuse already established connections.
- A lack of timeout configuration could be a point of DoS risk.
- A lack of redirect limitations could result in a trusted source initiating a blind SSRF.
I plan to address this by creating a public function for returning a well configured http.Client from the sdk
. Then utilize this client from within the SDK, platform, and backend broadly. If anyone has feedback on this design let me know in Slack or once I submit the PR.
Metadata
Metadata
Assignees
Labels
No labels