Skip to content

feat(policy): 1500 Attribute create with Values (one RPC Call) should employ a db transaction #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 2, 2024
Merged

feat(policy): 1500 Attribute create with Values (one RPC Call) should employ a db transaction #1778

merged 12 commits into from
Dec 2, 2024

Conversation

ryanulit
Copy link
Contributor

@ryanulit ryanulit commented Nov 21, 2024 •
edited
Loading

Proposed Changes

fix #1500

  • adds PolicyDbClient.RunInTx() method
  • updates attribute create to use the method

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@ryanulit ryanulit linked an issue Nov 21, 2024 that may be closed by this pull request
Policy: Creation of an Attribute with Values (one RPC call) should employ a db transaction #1500
Closed
@ryanulit ryanulit marked this pull request as ready for review November 22, 2024 01:40
@ryanulit ryanulit requested review from a team as code owners November 22, 2024 01:40
@ryanulit ryanulit mentioned this pull request Nov 25, 2024
Open
jakedoublev
jakedoublev reviewed Dec 2, 2024
View reviewed changes
@ryanulit ryanulit enabled auto-merge December 2, 2024 16:22
@ryanulit ryanulit added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@ryanulit ryanulit added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 90edbde Dec 2, 2024
22 checks passed
@ryanulit ryanulit deleted the 1500-create-attribute-with-values-should-use-txn branch December 2, 2024 16:54
@opentdf-automation opentdf-automation bot mentioned this pull request Dec 2, 2024
Merged
@ryanulit ryanulit mentioned this pull request Dec 2, 2024
Closed
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2024
@opentdf-automation
chore(main): release service 0.4.31 (#1794)
4a53744 
🤖 I have created a release *beep* *boop*
---


##
[0.4.31](service/v0.4.30...service/v0.4.31)
(2024-12-02)


### Features

* **kas:** collect metrics
([#1702](#1702))
([def28d1](def28d1))
* **policy:** 1500 Attribute create with Values (one RPC Call) should
employ a db transaction
([#1778](#1778))
([90edbde](90edbde))


### Bug Fixes

* **core:** move auth interceptor to top of chain
([#1790](#1790))
([f9f5a75](f9f5a75))
* **policy:** return fqns in list subject mappings
([#1796](#1796))
([c0a9dda](c0a9dda))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakedoublev jakedoublev jakedoublev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Policy: Creation of an Attribute with Values (one RPC call) should employ a db transaction

2 participants

@ryanulit @jakedoublev