Skip to content

fix(core): Return deny decision for empty entity chains #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2025
Merged

fix(core): Return deny decision for empty entity chains #1846

merged 4 commits into from
Jan 9, 2025

Conversation

elizabethhealy
Copy link
Member

Proposed Changes

  • deny for entity chain with no entities
  • permit for resource attribute with no fqns

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@elizabethhealy elizabethhealy marked this pull request as ready for review January 8, 2025 21:09
@elizabethhealy elizabethhealy requested a review from a team as a code owner January 8, 2025 21:09
dmihalcik-virtru
dmihalcik-virtru reviewed Jan 8, 2025
View reviewed changes
@dmihalcik-virtru dmihalcik-virtru added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 1e8b6a5 Jan 9, 2025
22 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the dsp-398-empty-entity-chain-handling-decision branch January 9, 2025 14:38
@opentdf-automation opentdf-automation bot mentioned this pull request Jan 9, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2025
@opentdf-automation
chore(main): release service 0.4.37 (#1843)
8f9b390 
🤖 I have created a release *beep* *boop*
---


##
[0.4.37](service/v0.4.36...service/v0.4.37)
(2025-01-09)


### Features

* **core:** Expose version info
([#1841](#1841))
([92a9f5e](92a9f5e))


### Bug Fixes

* **core:** Correct length of GetDecision response array
([#1839](#1839))
([85ce9b6](85ce9b6))
* **core:** Return deny decision for empty entity chains
([#1846](#1846))
([1e8b6a5](1e8b6a5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmihalcik-virtru dmihalcik-virtru dmihalcik-virtru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizabethhealy @dmihalcik-virtru