feat(sdk): Hide connect rpc client side #2206

elizabethhealy · 2025-05-12T19:14:40Z

Proposed Changes

generate connect wrappers for the grpc client interfaces, allows the sdk object to still have grpc client interfaces (meaning if someone is running a seperate ERS for example, it doesnt have to be connectrpc, same for the other services)

Checklist

I have added or updated unit tests
I have added or updated integration tests (if appropriate)
I have added or updated documentation

Testing Instructions

github-actions · 2025-05-12T19:19:30Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	457.364755ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	361.288115ms
Throughput	276.79 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m12.366554169s
Average Latency	721.004201ms
Throughput	69.09 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4945
Failed Requests	55
Concurrent Requests	50
Total Time	1m1.599413641s
Average Latency	612.79738ms
Throughput	80.28 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	55 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-12T19:22:53Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	463.951559ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	364.531489ms
Throughput	274.32 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m13.781486434s
Average Latency	735.760588ms
Throughput	67.77 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4952
Failed Requests	48
Concurrent Requests	50
Total Time	1m2.470667139s
Average Latency	620.055682ms
Throughput	79.27 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	48 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-12T20:08:16Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	448.942273ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	379.368991ms
Throughput	263.60 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m14.179125293s
Average Latency	740.112024ms
Throughput	67.40 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4947
Failed Requests	53
Concurrent Requests	50
Total Time	1m3.974014774s
Average Latency	634.746804ms
Throughput	77.33 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	53 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-12T20:11:52Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	479.520509ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	375.798449ms
Throughput	266.10 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m20.327228718s
Average Latency	800.754167ms
Throughput	62.25 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4947
Failed Requests	53
Concurrent Requests	50
Total Time	1m11.246486014s
Average Latency	709.045254ms
Throughput	69.44 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	53 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-12T20:33:09Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	474.425552ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	363.480331ms
Throughput	275.12 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m16.111739611s
Average Latency	758.573677ms
Throughput	65.69 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4966
Failed Requests	34
Concurrent Requests	50
Total Time	1m5.979237141s
Average Latency	654.99428ms
Throughput	75.27 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	34 occurrences

Standard Benchmark Metrics Skipped or Failed

elizabethhealy · 2025-05-14T18:57:59Z

.github/workflows/checks.yaml

      focus-sdk: go
      # use commit instead of ref so we can "go get" specific sdk version
      platform-ref: ${{ github.event.pull_request.head.sha || github.sha }} lts
+      otdfctl-ref: c9f4679d5d3205e4ccb9f6e81fdca973f498c8c5


TODO: remove before merging, just for tests

github-actions · 2025-05-14T19:02:22Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	456.41609ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	369.310787ms
Throughput	270.77 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m13.715812727s
Average Latency	735.152429ms
Throughput	67.83 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4934
Failed Requests	66
Concurrent Requests	50
Total Time	1m4.072554928s
Average Latency	635.406099ms
Throughput	77.01 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	66 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-14T19:20:01Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	475.390891ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	366.55799ms
Throughput	272.81 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m12.020796526s
Average Latency	717.991039ms
Throughput	69.42 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4948
Failed Requests	52
Concurrent Requests	50
Total Time	1m1.930442301s
Average Latency	615.859211ms
Throughput	79.90 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	52 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-14T19:24:40Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	453.615426ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	351.397254ms
Throughput	284.58 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m11.536481358s
Average Latency	713.071303ms
Throughput	69.89 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4948
Failed Requests	52
Concurrent Requests	50
Total Time	1m1.048419717s
Average Latency	606.264253ms
Throughput	81.05 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	52 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-15T03:22:04Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	454.088501ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	360.774543ms
Throughput	277.18 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m14.256432137s
Average Latency	740.701813ms
Throughput	67.33 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4945
Failed Requests	55
Concurrent Requests	50
Total Time	1m3.317441092s
Average Latency	628.834783ms
Throughput	78.10 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	55 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-15T03:41:01Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	458.46592ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	361.718589ms
Throughput	276.46 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m12.815757356s
Average Latency	726.22144ms
Throughput	68.67 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4937
Failed Requests	63
Concurrent Requests	50
Total Time	1m1.322450004s
Average Latency	609.786552ms
Throughput	80.51 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	63 occurrences

Standard Benchmark Metrics Skipped or Failed

github-actions · 2025-05-15T04:46:50Z

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	445.890566ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	367.903197ms
Throughput	271.81 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m17.551622358s
Average Latency	773.12204ms
Throughput	64.47 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4942
Failed Requests	58
Concurrent Requests	50
Total Time	1m5.91944207s
Average Latency	654.545564ms
Throughput	74.97 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	58 occurrences

Standard Benchmark Metrics Skipped or Failed

elizabethhealy added 2 commits May 12, 2025 15:13

add a connect rpc client wrapper

2ae67f9

go mod tidy

9e90b32

linting

74ec172

elizabethhealy changed the title ~~feat(sdk): DSPX-528 Hide connect rpc client side~~ feat(sdk): Hide connect rpc client side May 12, 2025

test against updated otdfctl branch

427977e

update otdfctl ref

752968a

generate code for connect wrappers

f39011e

elizabethhealy commented May 14, 2025

View reviewed changes

linting

e86cfc8

linting

5cfa150

fix authorization tests

14afa36

fmt and fix authz tests

1e5fe1a

update otdfctl ref

0f21d36

elizabethhealy marked this pull request as ready for review May 15, 2025 04:59

elizabethhealy requested review from a team as code owners May 15, 2025 04:59

elizabethhealy merged commit 3eeda98 into DSPX-528-go-client-connect-rpc May 15, 2025
16 of 21 checks passed

elizabethhealy deleted the dspx-528-obscure-connect-rpc-clientside branch May 15, 2025 05:00

feat(sdk): Hide connect rpc client side #2206

feat(sdk): Hide connect rpc client side #2206

Uh oh!

Conversation

elizabethhealy commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Checklist

Testing Instructions

Uh oh!

github-actions bot commented May 12, 2025

Benchmark Results:

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Error Summary:

Standard Benchmark Metrics Skipped or Failed

Uh oh!

github-actions bot commented May 12, 2025

Benchmark Results:

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Error Summary:

Standard Benchmark Metrics Skipped or Failed

Uh oh!

github-actions bot commented May 12, 2025

Benchmark Results:

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Error Summary:

Standard Benchmark Metrics Skipped or Failed

Uh oh!

github-actions bot commented May 12, 2025

Benchmark Results:

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Error Summary:

Standard Benchmark Metrics Skipped or Failed

Uh oh!

github-actions bot commented May 12, 2025

Benchmark Results:

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Error Summary:

Standard Benchmark Metrics Skipped or Failed

Uh oh!

elizabethhealy May 14, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 14, 2025

Benchmark Results:

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Error Summary:

Standard Benchmark Metrics Skipped or Failed

Uh oh!

github-actions bot commented May 14, 2025

Benchmark Results:

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Error Summary:

Standard Benchmark Metrics Skipped or Failed

Uh oh!

github-actions bot commented May 14, 2025

Benchmark Results:

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Error Summary:

Standard Benchmark Metrics Skipped or Failed

Uh oh!

github-actions bot commented May 15, 2025

Benchmark Results:

Bulk Benchmark Results

elizabethhealy commented May 12, 2025 •

edited

Loading