-
Notifications
You must be signed in to change notification settings - Fork 24
chore(ci): Adds sqlc/mermerd up-to-date checks #2610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've introduced new checks into our continuous integration (CI) pipeline to ensure that our generated Entity-Relationship Diagram (ERD) documentation and sqlc
generated code are always current. This enhancement aims to prevent outdated generated files from being committed, thereby improving code consistency and reliability within our development workflow.
Highlights
- CI/Build Process Enhancement: I've updated the Makefile to include
policy-sql-gen
as part of the mainbuild
target. This change ensures that thesqlc
generated code for policies is always up-to-date whenever a build is performed, which is crucial for maintaining code consistency in the CI pipeline.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
CI runs so fast,Generated code is fresh,No more stale files.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add CI checks to ensure generated files from sqlc
and mermerd
are up-to-date. The change correctly integrates the sqlc
generation step into the main build
target in the Makefile. However, the corresponding check for mermerd
-generated ERD files appears to be missing. My review includes a suggestion to add it, while also noting a potential dependency issue with mermerd
requiring a live database connection.
rm -f opentdf examples/examples | ||
|
||
build: proto-generate connect-wrapper-generate opentdf sdk/sdk examples/examples | ||
build: proto-generate policy-sql-gen connect-wrapper-generate opentdf sdk/sdk examples/examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description mentions adding up-to-date checks for both sqlc
and mermerd
. While the sqlc
check (policy-sql-gen
) is added to the build, the mermerd
check (policy-erd-gen
) appears to be missing from this target's dependencies.
If this was an oversight, you can add policy-erd-gen
here. However, be aware that policy-erd-gen
requires a running PostgreSQL database, which might be a consideration for the CI environment.
If adding the mermerd
check is out of scope for this PR, please consider updating the PR title and description for clarity.
build: proto-generate policy-sql-gen policy-erd-gen connect-wrapper-generate opentdf sdk/sdk examples/examples
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Proposed Changes
Checklist
Testing Instructions