Skip to content

Conversation

dmihalcik-virtru
Copy link
Member

Proposed Changes

  • Adds uo-to-date checks for generated ERD docs and diagrams, as well as sqlc code

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners August 1, 2025 20:48
@github-actions github-actions bot added comp:ci Github Actions Work size/s labels Aug 1, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've introduced new checks into our continuous integration (CI) pipeline to ensure that our generated Entity-Relationship Diagram (ERD) documentation and sqlc generated code are always current. This enhancement aims to prevent outdated generated files from being committed, thereby improving code consistency and reliability within our development workflow.

Highlights

  • CI/Build Process Enhancement: I've updated the Makefile to include policy-sql-gen as part of the main build target. This change ensures that the sqlc generated code for policies is always up-to-date whenever a build is performed, which is crucial for maintaining code consistency in the CI pipeline.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


CI runs so fast,Generated code is fresh,No more stale files.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dmihalcik-virtru dmihalcik-virtru mentioned this pull request Aug 1, 2025
3 tasks
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add CI checks to ensure generated files from sqlc and mermerd are up-to-date. The change correctly integrates the sqlc generation step into the main build target in the Makefile. However, the corresponding check for mermerd-generated ERD files appears to be missing. My review includes a suggestion to add it, while also noting a potential dependency issue with mermerd requiring a live database connection.

rm -f opentdf examples/examples

build: proto-generate connect-wrapper-generate opentdf sdk/sdk examples/examples
build: proto-generate policy-sql-gen connect-wrapper-generate opentdf sdk/sdk examples/examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description mentions adding up-to-date checks for both sqlc and mermerd. While the sqlc check (policy-sql-gen) is added to the build, the mermerd check (policy-erd-gen) appears to be missing from this target's dependencies.

If this was an oversight, you can add policy-erd-gen here. However, be aware that policy-erd-gen requires a running PostgreSQL database, which might be a consideration for the CI environment.

If adding the mermerd check is out of scope for this PR, please consider updating the PR title and description for clarity.

build: proto-generate policy-sql-gen policy-erd-gen connect-wrapper-generate opentdf sdk/sdk examples/examples

Copy link
Contributor

github-actions bot commented Aug 4, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 171.262606ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 100.524226ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 347.157865ms
Throughput 288.05 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 36.380321383s
Average Latency 361.066219ms
Throughput 137.44 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.524335639s
Average Latency 254.288987ms
Throughput 195.89 requests/second

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:ci Github Actions Work size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant