-
Notifications
You must be signed in to change notification settings - Fork 3
feat(sdk): Update to the latest service protos #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @elizabethhealy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the service protobufs, primarily by introducing a new, more robust authorization service (v2) and a comprehensive obligations service. It also includes substantial refactoring and deprecation of older key access server (KAS) related fields, moving towards a more explicit 'kas_keys' model and adding new key mapping capabilities. Key provider configurations are enhanced with a 'manager' field for better categorization and filtering. These changes aim to improve the clarity, functionality, and maintainability of the platform's policy and security infrastructure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant update to the SDK by regenerating the connectrpc code from the latest service protos. The changes include the addition of new services like authorization v2, entity resolution v2, and obligations, which is a substantial feature enhancement. The PR also thoughtfully deprecates older APIs, such as KAS-level grants, in favor of more granular and secure key-level grants, and provides clear deprecation notices. The introduction of additional checks in 'unsafe' APIs, like for key deletion, is a welcome safety improvement. My review found the changes to be consistent and well-structured. I have one suggestion to further improve the documentation for a critical 'unsafe' operation to enhance developer experience and prevent potential misuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @elizabethhealy, the generated stubs look great!
For the client stubs to become available in the SDK we need to create a client for them
Line 89 in 4979885
this.v1 = { |
Basically, we need something similar to this
import { AuthorizationService as AuthorizationServiceV2} from './platform/authorization/v2/authorization_pb.js';
this.v2 = {
authorization: createClient(AuthorizationService2, transport),
}
Regen the connectrpc code with the latest protos
Includes the addition of authorization v2, ers v2, and obligations