remove time spent active

[josh-willis-arcadis]

Description:

Removes the time spent active information in the trip preview layout

PR Checklist:

• Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
• Are all languages supported (Internationalization/Localization)?
• Are appropriate Typescript types implemented?

[miles-grant-ibigroup]

This needs to be configurable/displayed by default!

[josh-willis-arcadis]

good catch. I forgot to pull the config value.

[miles-grant-ibigroup]

Sorry to be a bother but since this is such a simple feature might it be better to disable this via css? I think a prop to hide a single row is clutter. Could we not just patch otp-ui to add a class name?

[miles-grant-ibigroup]

Dupe of #1394?

[josh-willis-arcadis]

Definitely a dupe of #1394. Which one do we like better? @miles-grant-ibigroup @daniel-heppner-ibigroup

[daniel-heppner-ibigroup]

Sorry but I like mine better because it passes in the config items with the other config stuff in the connect function. However I'm kinda with Miles that we should just do this with a CSS class.

[josh-willis-arcadis]

@daniel-heppner-ibigroup You have a cleaner solution so lets use your PR. The TripDetails component already supports the prop displayTimeActive so I think we should just leave it as is.

[danielhep]

I kinda feel like if we're going to have a config item for this, we should just go all the way and make it an array where you can specify all the items that get displayed in Trip Details. Like tripDetailsItems: ['fare', 'co2', 'timeActive', 'duration']

[josh-willis-arcadis]

@daniel-heppner-ibigroup that is a better long term solution. Can we use this as a stopgap for now and clean up the props/trip-details component in a future PR?

[miles-grant-ibigroup]

@daniel-heppner-ibigroup that is a better long term solution. Can we use this as a stopgap for now and clean up the props/trip-details component in a future PR?

Can we do the CSS approach instead? I really want to stop using these props

[josh-willis-arcadis]

yeah I will implement css. like this? @miles-grant-ibigroup

            <TripDetails
              className={`percy-hide${
                displayTimeActive ? ' show-time-active' : ''
              }`}
              itinerary={itinerary}
            />

[miles-grant-ibigroup]

yeah I will implement css. like this? @miles-grant-ibigroup

            <TripDetails
              className={`percy-hide${
                displayTimeActive ? ' show-time-active' : ''
              }`}
              itinerary={itinerary}
            />

Eeek! No! I meant more adding a time-active class to the time active row and removing the displayTimeActive prop entirely

[josh-willis-arcadis]

closing in favor of opentripplanner/otp-ui#841