Skip to content

[Snippets][CPU][DEBUG_CAPS] Implement RegPrinter for ARM64 #32124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Snippets][CPU][DEBUG_CAPS] Implement RegPrinter for ARM64 #32124

wants to merge 2 commits into from
+322 −1

Conversation

aobolensk
Copy link
Contributor

Tickets:

  • N/A

@aobolensk aobolensk requested review from a team as code owners September 17, 2025 16:34
@aobolensk aobolensk requested review from ValentinaKats and removed request for a team September 17, 2025 16:35
@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra category: docs OpenVINO documentation labels Sep 17, 2025
@aobolensk aobolensk changed the title [Snippets][DEBUG_CAPS] Implement RegPrinter for ARM64 [Snippets][CPU][DEBUG_CAPS] Implement RegPrinter for ARM64 Sep 17, 2025
@aobolensk aobolensk added the platform: arm OpenVINO on ARM / ARM64 label Sep 17, 2025
tsavina
tsavina reviewed Sep 18, 2025
View reviewed changes
src/plugins/intel_cpu/src/emitters/plugin/aarch64/debug_capabilities.cpp Outdated
} // namespace

template <typename T>
void RegPrinter::print_reg_prc(const char* name, const char* ori_name, T* ptr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ori_name -> orig_name is better abbreviation for original

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied

src/plugins/intel_cpu/src/emitters/plugin/aarch64/debug_capabilities.hpp Outdated
Comment on lines 18 to 20
// 1. Include this header in AArch64 JIT kernels when register printing is required.
// 2. Invoke RegPrinter::print method with a supported register/precision combination.
// Examples:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// 1. Include this header in AArch64 JIT kernels when register printing is required.
// 2. Invoke RegPrinter::print method with a supported register/precision combination.
// Examples:
// 1. Include this header in AArch64 JIT kernels if register printing is required.
// 2. Invoke the RegPrinter::print method with a supported register/precision combination.
// Examples:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsavina tsavina tsavina left review comments

@ValentinaKats ValentinaKats Awaiting requested review from ValentinaKats ValentinaKats is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

@v-Golubev v-Golubev

Labels
category: build OpenVINO cmake script / infra category: CPU OpenVINO CPU plugin category: docs OpenVINO documentation platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aobolensk @tsavina @v-Golubev