[fix] Preserve newline characters in input fields #19 #32
Conversation
…sp#19 Fixed an issue where newline characters () in input fields were removed when saving via the HTML form. Updated the logic to ensure newline characters are preserved in both display and saved data. Fixed openwisp#19
…sp#19 Fixed an issue where newline characters () in input fields were removed when saving via the HTML form. Updated the logic to ensure newline characters are preserved in both display and saved data. Fixes openwisp#19
mrgear111
changed the title
\n) in input fields were removed when saving via the HTML form. Updated the logic to ensure newline characters are preserved in both display and saved data. Fixed #19\n) in input fields were removed when saving via the HTML form. Updated the logic to ensure newline characters are preserved in both display and saved data. Fixed #19
|
@nemesifier can we please merge this? |
|
@nemesifier Can you please review this! |
github-project-automation
bot
moved this from Needs review
to Done
in OpenWISP Contributor's Board
nemesifier
changed the title
\n) in input fields were removed when saving via the HTML form. Updated the logic to ensure newline characters are preserved in both display and saved data. Fixed #19
There was a problem hiding this comment.
I am sorry but we got carried away with other activites with @openwisp and forgot to review this PR.
After looking at this solution, my question is: has anyone understood what causes the bug in the first place?
github-project-automation
bot
moved this from Done
to In progress
in OpenWISP Contributor's Board
|
Yes, I tried checking what happens when you use the \n character inside an input tag ( I don't remember properly but it was some related input or textarea ). |
|
So his solution simply adds |
[flat-json-widget] Preserve newline characters in input fields (#19)
Description:
This PR fixes an issue where newline characters (
\n) in input fields were being removed upon saving data through the HTML form. The logic has been updated to ensure that newline characters are preserved correctly in both the display and the saved data.Fixes #19
Checklist:
Testing:
This is my first time creating a PR, and I was trying to follow your contribution guidelines. I mistakenly committed four times, but the main fix is in the first commit. Please review it.