-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ZTS: add mount_loopback to test zfs behind loop dev #17329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8415e39
to
c967763
Compare
@behlendorf I included your fixes in my latest push. |
Two thoughts:
|
@robn -
Thanks - I just added a check in my latest push
Yes, its just a basic sanity test to verify "filesystem over loopback over ZFS". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
It should probably be specified somewhere that skipped test is OK:
|
This still fails (skips) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new test case to verify that ZFS-backed loopback devices work correctly with other filesystems, specifically addressing issue #17277 which was previously fixed by PR #17298.
- Adds a comprehensive test that creates both file-based and zvol-based loopback devices
- Tests XFS filesystem creation and I/O operations on ZFS-backed loopback devices
- Includes proper dependency checks for XFS support and required utilities
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 11 comments.
File | Description |
---|---|
tests/zfs-tests/tests/functional/mount/mount_loopback.ksh | New test script that creates loopback devices backed by ZFS and tests XFS filesystem operations |
tests/zfs-tests/tests/Makefile.am | Adds the new test script to the build system |
tests/zfs-tests/include/commands.cfg | Adds which and mkfs.xfs to available system commands for tests |
tests/runfiles/linux.run | Includes the new test in the Linux test suite |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Add a test case to reproduce issue openzfs#17277: 1. Make a pool 2. Write a file to the pool 3. Mount the file as a loopback device 4. Make an XFS filesystem on the loopback device 5. Mount the XFS filesystem... <hangs> Signed-off-by: Tony Hutter <[email protected]>
Add a test case to reproduce issue openzfs#17277: 1. Make a pool 2. Write a file to the pool 3. Mount the file as a loopback device 4. Make an XFS filesystem on the loopback device 5. Mount the XFS filesystem... <hangs> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Rob Norris <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tony Hutter <[email protected]> Issue openzfs#17277 Closes openzfs#17329
Add a test case to reproduce issue openzfs#17277: 1. Make a pool 2. Write a file to the pool 3. Mount the file as a loopback device 4. Make an XFS filesystem on the loopback device 5. Mount the XFS filesystem... <hangs> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Rob Norris <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tony Hutter <[email protected]> Issue openzfs#17277 Closes openzfs#17329
Motivation and Context
Add test for #17277
Description
Add a test case to reproduce issue #17277. This has actually been fixed by #17298, but add a test case for good measure. The test case verifies that we can make an xfs filesystem on a ZFS-backed loopback device.
How Has This Been Tested?
Test case added
Types of changes
Checklist:
Signed-off-by
.