Split SDK into multiple projects #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrodri
requested review from
estroz,
fabianvf,
hasbro17,
joelanford and
shawn-hurley
jmrodri
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
jmrodri
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
This shows fine for me. Regards the docs see: https://github.com/operator-framework/enhancements/pull/24/files#r433788330
Otherwise:
/lgtm
/approve
asmacdo
reviewed
Jun 2, 2020
|
/lgtm |
estroz
reviewed
Jun 2, 2020
estroz
approved these changes
Jun 2, 2020
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the overarching enhancement that will plan how to split functionality out of the current operator-sdk project into separate projects. The initial thought on component breakdown mirrors the kubebuilder and controller-runtime projects: