Skip to content

Make it possible for GenericKubernetesResourceMatcher consider metadata as well #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
metacosm opened this issue Aug 10, 2022 · 0 comments · Fixed by #1393
Closed

Make it possible for GenericKubernetesResourceMatcher consider metadata as well #1392

metacosm opened this issue Aug 10, 2022 · 0 comments · Fixed by #1393
Assignees
@metacosm
Labels
feature kind/feature Categorizes issue or PR as related to a new feature.

Comments

@metacosm
Copy link
Collaborator

metacosm commented Aug 10, 2022 •
edited
Loading

More specifically annotations and labels should be checked since the rest of the fields are either irrelevant (e.g. name) or not under a user's control (e.g. managedFields).
@metacosm metacosm added kind/feature Categorizes issue or PR as related to a new feature. feature labels Aug 10, 2022
@metacosm metacosm self-assigned this Aug 10, 2022
metacosm added a commit that referenced this issue Aug 10, 2022
@metacosm
feat: make it possible to also check annotations/labels when matching
c354331 
Fixes #1392
@metacosm metacosm mentioned this issue Aug 10, 2022
Merged
metacosm added a commit that referenced this issue Aug 24, 2022
@metacosm
feat: make it possible to also check annotations/labels when matching
acaaab0 
Fixes #1392
metacosm added a commit that referenced this issue Aug 25, 2022
@metacosm @csviri
feat: make it possible to also check annotations/labels when matching (…
97481a6 
…#1393)

Fixes #1392

Co-authored-by: csviri <[email protected]>
csviri added a commit that referenced this issue Aug 25, 2022
@metacosm @csviri
feat: make it possible to also check annotations/labels when matching (…
0ce8aea 
…#1393)

Fixes #1392

Co-authored-by: csviri <[email protected]>
csviri added a commit that referenced this issue Aug 30, 2022
@metacosm @csviri
feat: make it possible to also check annotations/labels when matching (…
249e942 
…#1393)

Fixes #1392

Co-authored-by: csviri <[email protected]>
@csviri csviri closed this as completed in 93cc8bb Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
feature kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
1 participant
@metacosm