Skip to content

Ability to turn off adding a finalizer #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shawkins opened this issue May 4, 2021 · 1 comment · Fixed by #424
Closed

Ability to turn off adding a finalizer #415

shawkins opened this issue May 4, 2021 · 1 comment · Fixed by #424
Assignees
@metacosm

Comments

@shawkins
Copy link
Collaborator

shawkins commented May 4, 2021

We would like an option to turn off adding a finalizer as we have no specially handling necessary upon deletion. The current logic will treat no finalizer in the annotation as specifying the default.

I tried a workaround of setting an invalid name in 1.8.2, but that just produces a lot of exceptions.
@metacosm metacosm self-assigned this May 4, 2021
@snowdrop-bot snowdrop-bot mentioned this issue May 4, 2021
Closed
metacosm added a commit that referenced this issue May 19, 2021
@metacosm
feat: make it possible to not automatically add finalizers
46e5ce3 
Fixes #415
metacosm added a commit that referenced this issue May 19, 2021
@metacosm
feat: make it possible to not automatically add finalizers
6c8ab47 
Fixes #415
@metacosm metacosm mentioned this issue May 19, 2021
Merged
metacosm added a commit that referenced this issue May 20, 2021
@metacosm
feat: make it possible to not automatically add finalizers
3b0170c 
Fixes #415
metacosm added a commit that referenced this issue May 20, 2021
@metacosm
feat: make it possible to not automatically add finalizers
d91f1f7 
Fixes #415
@shawkins
Copy link
Collaborator Author

Looks good, hopefully I'll be able to try it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make it possible to not automatically add finalizers operator-framework/java-operator-sdk
2 participants
@metacosm @shawkins