fix: avoid computing potentially unused values #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

metacosm merged 1 commit into main from fix-1758

Feb 9, 2023

Collaborator

metacosm commented Feb 6, 2023

Fixes #1758


          fix: avoid computing potentially unused values

84ee784

Fixes #1758

metacosm self-assigned this

metacosm requested a review from csviri

February 6, 2023 21:16

metacosm commented

View reviewed changes

...rc/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java

                       if (updatable) {
                         final Matcher.Result<R> match = match(actualResource, primary, context);
                         if (!match.matched()) {
-                          final var desired = match.computedDesired().orElse(desired(primary, context));
+                          final var desired = match.computedDesired().orElseGet(() -> desired(primary, context));

Collaborator Author

metacosm Feb 6, 2023

This is the salient part of the fix. I also took the opportunity to fix similar issues and low hanging fruits.

csviri approved these changes

View reviewed changes

Collaborator

csviri left a comment

LGTM

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

50.0% Coverage
0.0% Duplication

metacosm merged commit 5d8c567 into main

metacosm deleted the fix-1758 branch

February 9, 2023 15:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet