feat: add sample to primary to secondary missing issue #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrocquesel
reviewed
Apr 3, 2023
...ework/src/test/java/io/javaoperatorsdk/operator/sample/primarytosecondary/JobReconciler.java
Outdated
Show resolved
Hide resolved
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.awaitility.Awaitility.await; | ||
|
|
||
| class PrimaryToSecondaryMissingIT { |
There was a problem hiding this comment.
Maybe add some description that this unit test is to showcase the role of PtoS mapper and that it it not meant to be used as reusable code.
There was a problem hiding this comment.
makes sense, will add, thx!!
…ample/primarytosecondary/JobReconciler.java Co-authored-by: Sébastien CROCQUESEL <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
metacosm
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is this PR is to show why primary to secondary mapper is needed, serves to showcase the problematic use case.