Upgrade to Fabric8's 5.0 client and Quarkus 1.11.0.Final #288
Conversation
|
This is pure awesomeness, it simplifies usage a lot! Both in SDK and in the code we need to write to use CustomResources. So big 👍 |
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| public static final int INITIAL_DELAY = 50; | |||
| public static final int PERIOD = 50; | |||
| public static final int TESTING_TIME_SLACK = 20; | |||
| public static final int TESTING_TIME_SLACK = 40; | |||
There was a problem hiding this comment.
Doesn't look like it's working… 😞
There was a problem hiding this comment.
Right... maybe this type of test just isn't a good idea. Probably the Github runner is just really slow. Let me take another look.
There was a problem hiding this comment.
They also fail on my system, which, granted is not the fastest around… 😅
There was a problem hiding this comment.
I'll rewrite those tests so the timer is mocked, that's the only good solution.
|
Reverting back to draft pending release of Quarkus 1.11.0.Final so that the upgrade will be made to that version before this PR is merged. |
metacosm
changed the title
|
Should we merge this, @adam-sandor @psycho-ir ? |
Haven’t reviewed this PR yet. Will review it tomorrow |
Quarkus 1.11.0.CR1 is the first version to use Fabric8's client 5.0 so we need to update both at the same time. Note that tests are not expected to pass at this point yet.
The specific CR clients can now be easily retrieved from the fabric8 client using only the CR class.
|
LGTM |
|
I gave it a small smoke test (crud on my custom resource) and this PR seems to work. |
|
Found an issue thanks to @goldmann so reverting to draft untill I can solve it. |
|
I've tested latest changes with my not-so-trivial codebase and it works great! |
A controller is not cluster-scoped, its associated custom resource type is. As such, this functionality should (and is) controlled by the custom resource type associated with the controller, not the controller itself. If a custom resource implementation doesn't implement Namespaced then it is cluster-scoped.
|
LGTM |
Quarkus 1.11.0.Final is the first version to use Fabric8's client 5.0 so
we need to update both at the same time.
Overview of the changes:
Doneableclasses have been removed along with all the involved complexityControllerannotation has been simplified: thecrdNamefield has been removed as that value is computed from the associated custom resource implementationGroupandVersionannotations so that they can be identified properly. Optionally, they can also be annotated withKind(if the name of the implementation class doesn't match the desired kind) andPluralif the plural version cannot be automatically computed (or the default computed version doesn't match your expectations).CustomResourceclass that needs to be extended is now parameterized with spec and status types so you can have an empty default implementation that does what you'd expect. If you don't need a status, usingVoidfor the associated type should work.