Skip to content

fix(watchers): gracefully handle watch disconnection #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

goldmann
Copy link

@goldmann goldmann commented Jan 18, 2021

This is based on top of the https://github.com/java-operator-sdk/java-operator-sdk/tree/client-v5 branch. It's created to show a possible solution for the watcher cleanup.

Basically, the idea is to add a close() method for manual cleanup of watchers on the Operator class. I did not find an automatic way to solve it in general, ideas welcome.

For Quarkus though, this method is automatically called at the application shutdown, so for Quarkus - it is automatic.

Draft!

@metacosm
Copy link
Collaborator

That's more or less what I had in mind, yes. #303 is also supposed to clean-up the event source registration so that we can more easily track them and, in this particular context, indeed close their associated watch more easily.

@metacosm metacosm closed this Jan 18, 2021
@metacosm metacosm deleted the branch operator-framework:client-v5 January 18, 2021 12:54
@metacosm
Copy link
Collaborator

Hmm, looks like this got closed when I merged the client v5 branch and subsequently deleted it. Mind re-opening it against master, @goldmann?

@goldmann
Copy link
Author

Done: #309

@metacosm
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants