fix(watchers): gracefully handle watch disconnection #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of the https://github.com/java-operator-sdk/java-operator-sdk/tree/client-v5 branch. It's created to show a possible solution for the watcher cleanup.
Basically, the idea is to add a
close()
method for manual cleanup of watchers on theOperator
class. I did not find an automatic way to solve it in general, ideas welcome.For Quarkus though, this method is automatically called at the application shutdown, so for Quarkus - it is automatic.
Draft!