feat(quarkus): add support for externalized configuration #306
Conversation
| * contains {@link ControllerConfiguration#WATCH_ALL_NAMESPACES_MARKER} then the controller will | ||
| * watch all namespaces. | ||
| */ | ||
| @ConfigItem public Optional<List<String>> namespaces; |
There was a problem hiding this comment.
How about if this list is empty then the controller watches all namespaces? I think watching all namespaces is a sensible default as this will mostly be controlled by RBAC anyway by cluster admins not by configuring the operator.
There was a problem hiding this comment.
At the moment the default behavior is to watch the namespace the client is connected to (which should be the namespace the operator is deployed in), the idea being that you don't need to setup RBAC by default, which should make it easier to experiment with.
There was a problem hiding this comment.
Ok let's leave it like that for now. We could check what's the default in the operator-sdk and just run with that later.
There was a problem hiding this comment.
I will address this in #303
...time/src/main/java/io/javaoperatorsdk/quarkus/extension/ExternalControllerConfiguration.java
Outdated
Show resolved
Hide resolved
|
LGTM |
No description provided.