Skip to content

Event handler waits a long time before terminating #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

lburgazzoli
Copy link
Collaborator

Fixes #436

@lburgazzoli lburgazzoli force-pushed the gh-436 branch 2 times, most recently from 208c8a6 to 27c50a3 Compare June 13, 2021 09:07
@lburgazzoli lburgazzoli changed the title Event handler waits a long time before terminating #436 Event handler waits a long time before terminating Jun 13, 2021
@lburgazzoli
Copy link
Collaborator Author

lburgazzoli commented Jun 13, 2021

@metacosm this was the cause of the operator being perceived to not to handle ^C properly, in fact it was just waiting for the executors to terminate and since I have 4 controllers in my operator, the waiting time was about ~ 40 seconds (10s is the default timeout per controller).

Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! 🤦🏼

@metacosm metacosm merged commit 940b0cd into operator-framework:master Jun 14, 2021
@lburgazzoli lburgazzoli deleted the gh-436 branch June 14, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event handler waits a long time before terminating
2 participants