Skip to content

feat: provide KubernetesClient access from context #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Jan 5, 2022

No description provided.

@metacosm metacosm added this to the v2 milestone Jan 5, 2022
@metacosm metacosm added kind/feature Categorizes issue or PR as related to a new feature. api-changes-epic labels Jan 5, 2022
@metacosm metacosm self-assigned this Jan 5, 2022
@metacosm metacosm requested a review from csviri January 5, 2022 20:32
@csviri
Copy link
Collaborator

csviri commented Jan 6, 2022

@metacosm are you sure this is needed? This is for the case when the client would be build by the SDK? (not happening now) Or just a convenient feature?
Not enought to pass it to the constructor?
Also should we put it also to the context?

Just thinking loud :)

@metacosm
Copy link
Collaborator Author

metacosm commented Jan 6, 2022

This is to enable use cases like this: https://github.com/java-operator-sdk/java-operator-sdk/pull/785/files#diff-b2e8a6070866bd0d784849eb8fd8fc075c14c78b91ec07b502c339a4d45a7056 where basically the client is not available where the object is created.

@metacosm metacosm merged commit 29b0546 into main Jan 7, 2022
@metacosm metacosm deleted the kube-client branch January 7, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes-epic kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants