Skip to content

[tech debt] migrate operator-controller command handling to cobra #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grokspawn opened this issue Jan 27, 2025 · 5 comments
Closed

[tech debt] migrate operator-controller command handling to cobra #1650

grokspawn opened this issue Jan 27, 2025 · 5 comments
Assignees
@o-farag
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. v1.x Issues related to OLMv1 features that come after 1.0

Comments

@grokspawn
Copy link
Contributor

grokspawn commented Jan 27, 2025 •
edited
Loading

(clone of #1567 which applied to catalogd flag handling)

Maintenance/update of operator-controller flag handling would be greatly simplified by adopting https://github.com/spf13/cobra
@grokspawn grokspawn added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. v1.x Issues related to OLMv1 features that come after 1.0 labels Jan 27, 2025
@grokspawn grokspawn added this to OLM v1 Jan 27, 2025
@o-farag
Copy link
Contributor

o-farag commented Jan 29, 2025

Hello, I'd like to work on this. The first link isn't working, did you mean https://github.com/operator-framework/operator-controller/blob/main/cmd/operator-controller/main.go ?

@o-farag
Copy link
Contributor

o-farag commented Jan 31, 2025

@grokspawn , may I get some clarification so I can start working on the issue? Thank you

@grokspawn
Copy link
Contributor Author

Hi @o-farag. You're correct that it's for operator-controller's flag handling, and I fudged the URL. I fixed it.

@o-farag
Copy link
Contributor

o-farag commented Feb 4, 2025

Awesome, I'll start working on this then if no one else has

@o-farag o-farag mentioned this issue Feb 5, 2025
Merged
4 tasks
@o-farag
Copy link
Contributor

o-farag commented Feb 5, 2025

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@o-farag o-farag

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. v1.x Issues related to OLMv1 features that come after 1.0
Projects
OLM v1
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@o-farag @grokspawn