✨ Migrate operator-controller cli handling to cobra

[o-farag]

Description

Migrate operator-controller cli command handling to cobra

Maintain/update flag handling by migrating to cobra as requested @ #1650

Changes:

• Stopped using pflags, moved to cobra
• Changed how the version flag is processed, instead adding it as a subcommand
• Moved flag processing/validation out of main()
• Integrated cobra error handling with RunE while preserving setupLog error messages

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	d04c967
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/67ae7916deef550008e8e485
😎 Deploy Preview	https://deploy-preview-1717--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[o-farag]

Some notes:

• run() is monolithic and contains most of what used to be main(). I can break it up into helper functions if that's better, but I don't see a reason for it (other than maybe improved readability)
• I made all changes in main.go, without introducing the file structure recommended in the cobra user guide. I can also change it to follow that guide, at the cost of having more files
• Instead of having all errors go through RunE, I log all errors with RunE but allow errors that used setupLog to also still use that. I can change it to only one or the other if that's better

[o-farag]

@grokspawn could I get the workflow approved? I'd like to know id there's anything I need to fix. Thank you

[tmshort]

This needs a rebase. Also, you'll likely want to do catalogd/cmd/catalogd/main.go as well (if not in this PR, then another).

[LalatenduMohanty]

@o-farag Sorry about the delay in reviewing the PR. Once you rebase the PR will review it. Thanks.

[o-farag]

This needs a rebase. Also, you'll likely want to do catalogd/cmd/catalogd/main.go as well (if not in this PR, then another).

I believe this PR takes care of catalogd: #1598

[o-farag]

@LalatenduMohanty thanks for letting me know, I've rebased it

[o-farag]

/retest

[openshift-ci]

@o-farag: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[o-farag]

The e2e-kind test runs successfully on my own repo, and I have no failing tests locally

[LalatenduMohanty]

The e2e-kind test runs successfully on my own repo, and I have no failing tests locally

Looks like a flake. We can rerun it to test once the PR review is done.

[LalatenduMohanty]

By replacing os.Exit(1) with return err it is changing the binary's behavior little bit. With the current change we will error out if flags are not used properly and print the usage as well. Previously we wont print the usage. But the new behavior is better IMO.

[LalatenduMohanty]

/lgtm

[LalatenduMohanty]

/hold for someone from the maintainers group to take a look. Maintainers, feel free to remove the hold.

[codecov]

Codecov Report

Attention: Patch coverage is 52.38095% with 40 lines in your changes missing coverage. Please review.

Project coverage is 68.24%. Comparing base (ee8d821) to head (d04c967).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/operator-controller/main.go	52.38%	34 Missing and 6 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
- Coverage   68.29%   68.24%   -0.05%     
==========================================
  Files          63       63              
  Lines        5116     5121       +5     
==========================================
+ Hits         3494     3495       +1     
- Misses       1392     1396       +4     
  Partials      230      230              

Flag	Coverage Δ
e2e	51.59% <52.38%> (-0.12%)	⬇️
unit	55.86% <0.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tmshort]

/lgtm

[tmshort]

/unhold

[tmshort]

Thank you for your contribution!