Description
While reviewing the makefile I noticed several potential issues:
-
The
install
target, which does not build anything depends on thegenerate
target which invokescontroller-gen
to updateDeepCopy, DeepCopyInfo and
DeepCopyObjectmethods. The
generatecommand _should_ probably be a dependency of
build-linuxor
build`. -
The
install
target does not allow for specifying anyIMG
, so it assumes the default image name. Thedeploy
target can be used to install -
The
uninstall
target removes CRDs, but theinstall
target installs everything (and is used byrun
). -
The
deploy
target installs the controller, theundeploy
target removes everything. (This is OK.) -
The
quickstart
target creates a manifest (operator-controller.yaml), but ignores it in favor of a released version.