Skip to content

Makefile inconsistencies #226

Closed
Closed
@tmshort

Description

@tmshort

While reviewing the makefile I noticed several potential issues:

  1. The install target, which does not build anything depends on the generate target which invokes controller-gen to update DeepCopy, DeepCopyInfo and DeepCopyObjectmethods. Thegeneratecommand _should_ probably be a dependency ofbuild-linuxorbuild`.

  2. The install target does not allow for specifying any IMG, so it assumes the default image name. The deploy target can be used to install

  3. The uninstall target removes CRDs, but the install target installs everything (and is used by run).

  4. The deploy target installs the controller, the undeploy target removes everything. (This is OK.)

  5. The quickstart target creates a manifest (operator-controller.yaml), but ignores it in favor of a released version.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions