-
Notifications
You must be signed in to change notification settings - Fork 62
Remove dependency on github.com/blang/semver
#430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Comments
Ah! I see this thread now. We need blang to support Closing this one. |
We can't get rid of |
LalatenduMohanty
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this issue
Dec 19, 2024
…r-framework#430) Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.10 to 1.17.11. - [Release notes](https://github.com/klauspost/compress/releases) - [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml) - [Commits](klauspost/compress@v1.17.10...v1.17.11) --- updated-dependencies: - dependency-name: github.com/klauspost/compress dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Since #374 we have dependency on both
github.com/blang/semver
andgithub.com/Masterminds/semver
. We introducedgithub.com/Masterminds/semver
so that we can support certain version range syntax (#379).I believe we should be able to get rid of dependency on
github.com/blang/semver
. As far as I see, the only place where we use it is here:operator-controller/internal/catalogmetadata/filter/bundle_predicates.go
Lines 34 to 42 in 05ffd85
This piece of code was migrated from old entity source code.
And we only use
InBlangSemverRange
here.I believe we can replace
InBlangSemverRange
withInMastermindsSemverRange
in this ocassion.The text was updated successfully, but these errors were encountered: