✨ Add Service Account requirement to ClusterExtension #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
everettraven
reviewed
Jul 5, 2024
everettraven
reviewed
Jul 5, 2024
makon57
force-pushed
the
add-sa2ce
branch
2 times, most recently
from
4b8ce19 to
72cae75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 78.05% 77.57% -0.48%
==========================================
Files 18 18
Lines 1253 1262 +9
==========================================
+ Hits 978 979 +1
- Misses 193 201 +8
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bentito
reviewed
Jul 8, 2024
joelanford
reviewed
Jul 8, 2024
joelanford
reviewed
Jul 8, 2024
joelanford
reviewed
Jul 8, 2024
…sions Signed-off-by: Manna Kong <[email protected]>
joelanford
reviewed
Jul 8, 2024
makon57
force-pushed
the
add-sa2ce
branch
2 times, most recently
from
c6a3bd5 to
74f02ac
Compare
Signed-off-by: Manna Kong <[email protected]>
joelanford
approved these changes
Jul 9, 2024
everettraven
reviewed
Jul 9, 2024
everettraven
approved these changes
Jul 9, 2024
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Merged
via the queue into
operator-framework:main
with commit Jul 9, 2024
feaeece
15 of 17 checks passed
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
…work#1011) * Added service account as a required, immutable field for ClusterExtensions Signed-off-by: Manna Kong <[email protected]> * Added unit test and e2e test Signed-off-by: Manna Kong <[email protected]> --------- Signed-off-by: Manna Kong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves Issue #971 - Add new required field to ClusterExtension spec for users to reference a ServiceAccount
Reviewer Checklist