✨ fix a v1 promotion doc mistake #1448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Ah, thanks for catching this. We can merge this to main and it should be appropriately reflected in the docs site even after the release candidate release is finished |
| apiVersion: olm.operatorframework.io/v1 | ||
| apiVersion: olm.operatorframework.io/v1alpha1 |
There was a problem hiding this comment.
This actually should be v1, not v1alpha1. We completed the v1 API bump for the ClusterExtension API as of #1228
There was a problem hiding this comment.
Right. I was going to push changes to that PR, but it ... merged under me, and I mistakenly transplanted the v1alpha1 stuff.
m1kola
previously approved these changes
Nov 13, 2024
|
Need #1451 to go in first, it seems. Or a force merge since this is just docs (I don't have permissions). |
* Bump catalogd to v1 Signed-off-by: Per Goncalves da Silva <[email protected]> * update catalogd dep to v1.0.0-rc1 Signed-off-by: everettraven <[email protected]> * run make verify to regenerate generated content Signed-off-by: everettraven <[email protected]> --------- Signed-off-by: Per Goncalves da Silva <[email protected]> Signed-off-by: everettraven <[email protected]> Co-authored-by: Per Goncalves da Silva <[email protected]> Co-authored-by: everettraven <[email protected]>
grokspawn
force-pushed
the
post-v1-corrections
branch
from
3699fa8 to
2c08a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LalatenduMohanty , @everettraven y'all were going so 🚀 on #1441 that I didn't get a chance to complete review. It looks like you caught the things that I caught as well, except for this minor docs issue. We could conceivably ignore this and it will become correct once we complete v1 api promotion in operator-controller.
On the off case that we want to keep it consistent with context, here's this PR.
Description
Reviewer Checklist