Skip to content

🌱 enable go-apidiff in merge queue #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joelanford
Copy link
Member

Now that our APIs are stable, we have made go-apidiff a required check in CI. As such, we need it to be enabled in the merge queue.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner November 25, 2024 21:15
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 00c3abc
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6744e8fc6a54c400086b9edc
😎 Deploy Preview https://deploy-preview-1497--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joelanford joelanford enabled auto-merge November 25, 2024 21:18
@joelanford joelanford added this pull request to the merge queue Nov 25, 2024
Merged via the queue into operator-framework:main with commit a723f9a Nov 25, 2024
15 checks passed
@joelanford joelanford deleted the go-apidiff-merge-queue branch December 12, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants