🌱 Remove ginkgo from registryv1 tests #1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
reviewed
Nov 26, 2024
tmshort
commented
Nov 26, 2024
| t.Log("It should read the registry+v1 bundle filesystem correctly") | ||
| t.Log("It should include metadata/properties.yaml and csv.metadata.annotations['olm.properties'] in chart metadata") | ||
| fsys := os.DirFS("testdata/combine-properties-bundle") | ||
| chrt, err := RegistryV1ToHelmChart(context.Background(), fsys, "", nil) |
There was a problem hiding this comment.
@joelanford It's called here.
tmshort
force-pushed
the
remove-ginkgo
branch
from
a465424 to
f72f84a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 42 42
Lines 3271 3271
=======================================
Hits 2443 2443
Misses 652 652
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
everettraven
previously approved these changes
Nov 26, 2024
|
Will wait until 1.0.0 is tagged. |
openshift-merge-robot
added
the
needs-rebase
Fix: operator-framework#1496 Signed-off-by: Todd Short <[email protected]>
tmshort
force-pushed
the
remove-ginkgo
branch
from
f72f84a to
707eaec
Compare
openshift-merge-robot
removed
the
needs-rebase
LalatenduMohanty
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1496
Description
Reviewer Checklist