🐛 catalogd: e2e metrics: Do not use a fixed namespace for metrics tests #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow op-con's lead on specifying a metrics address Signed-off-by: Todd Short <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 57 57
Lines 4584 4584
=======================================
Hits 3057 3057
Misses 1302 1302
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -108,7 +108,7 @@ func TestCatalogdMetricsExportedEndpoint(t *testing.T) { | |||
| require.NoError(t, waitErr, "Error waiting for curl pod to be ready: %s", string(waitOutput)) | |||
|
|
|||
| t.Log("Validating the metrics endpoint") | |||
| metricsURL := "https://catalogd-service.olmv1-system.svc.cluster.local:7443/metrics" | |||
| metricsURL := "https://catalogd-service." + namespace + ".svc.cluster.local:7443/metrics" | |||
There was a problem hiding this comment.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow op-con's lead on specifying a metrics address
Description
Reviewer Checklist