✨ Upgrade bingo - tools #1610
Merged
✨ Upgrade bingo - tools #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
==========================================
- Coverage 66.68% 66.66% -0.03%
==========================================
Files 57 57
Lines 4584 4584
==========================================
- Hits 3057 3056 -1
- Misses 1302 1303 +1
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
perdasilva
force-pushed
the
upgrade-bingo-tools
branch
from
8a53474 to
0f69de2
Compare
perdasilva
previously approved these changes
Jan 14, 2025
|
Can ignore |
Signed-off-by: Per Goncalves da Silva <[email protected]>
Following the error fixed.
make lint GOLANGCI_LINT_ARGS="--out-format colored-line-number"
/Users/camilam/go/bin/golangci-lint-v1.63.4 run --build-tags containers_image_openpgp --out-format colored-line-number
internal/rukpak/convert/registryv1_test.go:489:2: encoded-compare: use require.JSONEq (testifylint)
require.Equal(t, `[{"type":"from-csv-annotations-key","value":"from-csv-annotations-value"},{"type":"from-file-key","value":"from-file-value"}]`, chrt.Metadata.Annotations[olmProperties])
perdasilva
force-pushed
the
upgrade-bingo-tools
branch
from
0f69de2 to
870838a
Compare
perdasilva
approved these changes
Jan 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
operator-framework:main
with commit Jan 14, 2025
8b93dce
22 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist