🐛 remove reference to non-existent target #1617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Per Goncalves da Silva <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
:+1 I've seen that but thought it would be cleaned up shortly in the upcoming phase of monorepo. Anyway, |
azych
approved these changes
Jan 15, 2025
perdasilva
changed the title
perdasilva
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
- Coverage 66.68% 66.66% -0.03%
==========================================
Files 57 57
Lines 4584 4584
==========================================
- Hits 3057 3056 -1
- Misses 1302 1303 +1
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -147,7 +147,7 @@ verify-crd-compatibility: $(CRD_DIFF) manifests | |||
| $(CRD_DIFF) --config="${CRD_DIFF_CONFIG}" "git://${CRD_DIFF_ORIGINAL_REF}?path=config/base/crd/bases/olm.operatorframework.io_clusterextensions.yaml" ${CRD_DIFF_UPDATED_SOURCE} | |||
|
|
|||
| .PHONY: test | |||
| test: manifests generate generate-catalogd fmt vet test-unit test-e2e #HELP Run all tests. | |||
| test: manifests generate fmt vet test-unit test-e2e #HELP Run all tests. | |||
Merged
via the queue into
operator-framework:main
with commit Jan 15, 2025
4223731
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed the test target references a no longer existent
generate-catalogdtarget. Just cleaning that up.Reviewer Checklist