Skip to content

🐛 Replace deprecated upload action for e2e #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Jan 16, 2025

E2E is failing due to an action we use which in turn uses a deprecated version of actions/upload-artifact. Confusingly, the article here states that this will happen on the 30th, and yet it's failing today (example)

@dtfranz dtfranz requested a review from a team as a code owner January 16, 2025 16:38
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 5f20c36
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6789360f05a4c10008baf883
😎 Deploy Preview https://deploy-preview-1632--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@perdasilva perdasilva added this pull request to the merge queue Jan 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2025
Merged via the queue into operator-framework:main with commit 13c9204 Jan 16, 2025
20 checks passed
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.71%. Comparing base (c2dfa2e) to head (5f20c36).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1632   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files          57       57           
  Lines        4588     4588           
=======================================
  Hits         3061     3061           
  Misses       1302     1302           
  Partials      225      225           
Flag Coverage Δ
e2e 52.66% <ø> (-0.09%) ⬇️
unit 53.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants