🐛 [Monorepo] fix: add ginkgo as a bingo dependency for catalogd #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
changed the title
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
c/c @azych could you give a hand here since you were terrific and spot this one !!!! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1635 +/- ##
==========================================
+ Coverage 66.70% 66.72% +0.02%
==========================================
Files 57 57
Lines 4595 4595
==========================================
+ Hits 3065 3066 +1
+ Misses 1304 1303 -1
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camilamacedo86
force-pushed
the
add-ginkgo
branch
from
ac2c293 to
913b8f1
Compare
grokspawn
reviewed
Jan 17, 2025
thank you for fixing this, LGTM :) |
azych
approved these changes
Jan 17, 2025
The tests were failing silently with the following error: trace -vv test/upgrade bash: line 1: trace: command not found This issue occurred because Ginkgo was not found to execute the tests with the specified options.
camilamacedo86
force-pushed
the
add-ginkgo
branch
from
3834dd4 to
94ccb2c
Compare
grokspawn
approved these changes
Jan 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
The tests were failing silently with the following error: trace -vv test/upgrade bash: line 1: trace: command not found This issue occurred because Ginkgo was not found to execute the tests with the specified options.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were failing silently with the following error: trace -vv test/upgrade
bash: line 1: trace: command not found
This issue occurred because Ginkgo was not found to execute the tests with the specified options. For example:$(GINKGO) $ (E2E_FLAGS) -trace -vv $(FOCUS) test/upgrade
Example:
Before this PR
Now:
Description
Reviewer Checklist